[HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] [$1000] Web - Request a money - Clicking on the avatar open a wrong profile

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a chat room from LHN
2. request a money
3. hover the avatar and click to open the profile

Expected Result:

the profile should be correct

Actual Result:

the wrong profile is opened

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.52-5

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screenshare.-.2023-08-10.9_43_12.PM.mp4

Recording.1160.mp4

Expensify/Expensify Issue URL:

Issue reported by: @misgana96

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691692716326279

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bdaad0efa1ea99ef
• Upwork Job ID: 1690773617761824768
• Last Price Increase: 2023-08-13
• Automatic offers:
• spcheema | Contributor | 26150022

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[daordonez11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking on the avatar opens a different profile.

What is the root cause of that problem?

In ReportActionItemSingle the MultipleAvatars component is inside a PressableWithoutFeedback even if you click outside the avatars you get the same result because it always calls showActorDetailswhich uses actorAccountID and in this case, we could use secondaryUserDetails information.

What changes do you think we should make in order to solve the problem?

1. Implement same as in group header which only shows the tooltips. We could do nothing in the showActorDetails something like:

 const showActorDetails = useCallback(() => {
        if (displayAllActors) {
            return
        }
        if (isWorkspaceActor) {
            showWorkspaceDetails(props.report.reportID);
        } else {
            showUserDetails(props.action.delegateAccountID ? props.action.delegateAccountID : actorAccountID);
        }
    },

2. Implement a new handler to check which element was clicked in MultipleAvatars and return the details of the clicked user

Update: After reviewing Mitch response the idea would be to solve the opening of a wrong profile here is my proposal on how to solve it.

• Create a new method in ReportActionItemSingle showAvatarProfile, which receives the information of an avatar and opens the profile

const showAvatarProfile = useCallback((avatarInfo) => {
       if (!avatarInfo) {
           return
       }
      showUserDetails(avatarInfo.id);
   },

Update 2: after Rocio's clarify we can leave the generic handler but here instead of showing user details we can send directly to the getParticipants path but leave the rest generic if any parent component requires specific implementation.

• Create a new callback in MultipleAvatars called onAvatarClicked, when an element of the component is clicked we can send back the information of the icon using props.icons[i].
• Create a handler in Avatar to check when it is clicked and send back the information
• Finally remove the PressableWithoutFeedback from ReportActionItemSingle to avoid double click interaction.

What alternative solutions did you explore? (Optional)

[spcheema]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking on the avatar opens a different profile.

What is the root cause of that problem?

The MultipleAvatars component is wrapped inside PressableWithoutFeedback and shows the profile of the actorAccountID.

So no matter what avatar is clicked, results is the same.

What changes do you think we should make in order to solve the problem?

In the case of iou report having multiple avatars, we can redirect to the details page similar to the multiple participant route.

Update showActorDetails call back to show multiple participants

    const showActorDetails = useCallback(() => {
        if (isWorkspaceActor) {
            showWorkspaceDetails(props.report.reportID);
        } else {
+            if (displayAllActors)
+            {
+                Navigation.navigate(ROUTES.getReportParticipantsRoute(props.iouReport.reportID));
+                return
+            }
            showUserDetails(props.action.delegateAccountID ? props.action.delegateAccountID : actorAccountID);
        }
    }, [isWorkspaceActor, props.report.reportID, actorAccountID, props.action.delegateAccountID]);

On multiple participant pages check the report type and show owner details along with props.action.delegateAccountID.

 const getAllParticipants = (report, personalDetails, translate) => {
-    const {participantAccountIDs} = report;
+    let participantAccountIDs = report.participantAccountIDs;
+
+    if (ReportUtils.isIOUReport(report))
+    {
+        participantAccountIDs  = [report.ownerAccountID, ...participantAccountIDs];
+    }

What alternative solutions did you explore? (Optional)

• Implement PressableWithoutFeedback component inside the multiple avatars component
• Add a new prop to multiple avatars component for clickable callback which will showActorDetails

I won't prefer this approach because MultipleAvatars is used in many places and may cause regression.

61.New.Expensify.-.14.August.2023.mp4

[MitchExpensify]

I feel like if we fix this we should fix it everywhere at once if possible. For example I'd expect to open up the correct profile depending on the avatar I click in the header of a request too

[spcheema]

@MitchExpensify for IOU report clicking the header doesn't show the profile/details page instead opens the chat report of the From. I believe it's expected behavior.

[MitchExpensify]

Cool, I think I'd expect to open a profile anytime I click an avatar but that conversation can be had elsewhere

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bdaad0efa1ea99ef

[melvin-bot]

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.