[HOLD #23088] Chat - Email tooltip stays when clicked on opponent's email

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Hover email
3. Once you see tooltip -> Tap to open detail

Expected Result:

Tooltip should removed when clicked email

Actual Result:

Tooltip stays until you move your cursor

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Safari
• MacOS / Desktop

Version Number: 1.3.51.0

Reproducible in staging?: needs reproduction

Reproducible in production?: needs reproduction

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-02.at.2.06.30.AM.mov

Expensify/Expensify Issue URL:

Issue reported by: @DinalJivani

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690922362632229

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[getusha]

Able to reproduce this, i think this should be listed in #23088 since it is safari-specific bug.

[Charan-hs]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Email tooltip stays when clicked on opponent's email

What is the root cause of that problem?

• The current implementation of the code doesn't include code that triggers the Tooltip to update its state based on MouseClick or MouseDown events. As a result, the information displayed in the Tooltip will only be updated when the user moves the mouse.

App/src/components/Hoverable/index.js

Lines 93 to 108 in c70a619

	},
	onMouseEnter: (el) => {
	this.setIsHovered(true);
	if (_.isFunction(child.props.onMouseEnter)) {
	child.props.onMouseEnter(el);
	}
	},
	onMouseLeave: (el) => {
	this.setIsHovered(false);
	if (_.isFunction(child.props.onMouseLeave)) {
	child.props.onMouseLeave(el);
	}
	},
	onBlur: (el) => {

What changes do you think we should make in order to solve the problem?

• Here Hoverable/index.js we can add this onMouseDown event.

  onMouseDown: (el) => {
                this.setIsHovered(false);

                if (_.isFunction(child.props.onMouseLeave)) {
                    child.props.onMouseDown(el);
                }
            }

Screen.Recording.2023-08-09.at.3.01.32.AM.mov

What alternative solutions did you explore? (Optional)

NA

[ygshbht]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The email tooltip in chat remains active after clicking, behaving inconsistently across Chrome and Safari.

What is the root cause of that problem?

Chrome triggers onMouseLeave when another element overlays the item, while Safari doesn't. This leads to the tooltip staying visible in Safari until the cursor is moved.

What changes do you think we should make in order to solve the problem?

To address the tooltip persistence issue, we can introduce a click event listener on the Hoverable component. Upon an email click, we can determine if the clicked element is under the cursor using the document.elementFromPoint() method. If the clicked element is found to not be the topmost, we can programmatically hide the tooltip by invoking setIsHovered(false). Recognizing that there might be a delay in modal rendering upon click, utilities like a setTimeout function can be employed to cater for this delay, with a brief, adjustable pause ranging from 20 to 100 ms. Even a delay of 0s appears to work. The primary advantage of this approach is that it ensures tooltips remain visible only when no overlaying component is rendered on top.

onClick: (event) => {
    setTimeout(() => {
        const elementUnderCursor = document.elementFromPoint(event.clientX, event.clientY);
        if (!(elementUnderCursor === this.wrapperView || this.wrapperView.contains(elementUnderCursor))) {
            this.setIsHovered(false);
        }
    }, 20);

    if (_.isFunction(child.props.onClick)) {
        child.props.onClick(el);
    }
},

Alternative strategies for consideration could involve techniques like MutationObserver and periodic polling. Implementing these changes is expected to standardize the tooltip behavior across both Chrome and Safari, enhancing the user experience.

What alternative solutions did you explore? (Optional)

Make Chrome like Safari too

output_fast.mp4

[dylanexpensify]

Reviewing today!

[dylanexpensify]

Hold