[HOLD for payment 2023-08-24] [$1000] It must show the detail of the user's profile that assigns the task

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

*First login to different accounts with two different users, one as user A and the other as user B
1-[User A] Click plus sign
2-[User A] Open Assign task
3-[User A] Write a title and click Next button
4-[User A] Select User B in Share somewhere and click Confirm task button
5-[User B] Open the task assign by the User A
6-[User B] Click on the profile picture

Expected Result:

It should show the detail of User A as shown in any Thread created by them. Do not show the "Settings" tab, as this is HELD on a future redesign.

Actual Result:

Show the detail the User B.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.47-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.5710.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Mauri-salazar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690804316551009

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011911d675e889edb8
• Upwork Job ID: 1687508460543074304
• Last Price Increase: 2023-08-04
• Automatic offers:
• s77rt | Reviewer | 26033003
• BhuvaneshPatil | Contributor | 26033006

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mvtglobally]

proposal from reporting contributor

Proposed solution

Please re-state the problem that we are trying to solve in this issue.

It must show the detail of the user's profile that assigns the task
What is the root cause of that problem?
For task reports, participantAccountIDs refers to the task assignee. On selecting a task report, it shows the correct avatar of the task creator but participantAccountID is used to navigate to the profile page. That's why it's showing incorrect profile details
What changes do you think we should make in order to solve the problem?
Add a condition inside the ReportUtils.navigateToDetailsPage function to check if a given report type is TASK then use report.ownerAccountID for navigation otherwise participantAccountID.

App/src/libs/ReportUtils.js

Line 1386 in dc32700

Navigation.navigate(ROUTES.getProfileRoute(participantAccountIDs[0]));

if (participantAccountIDs.length === 1) {
Navigation.navigate(ROUTES.getProfileRoute(
report.type === CONST.REPORT.TYPE.TASK ? report.ownerAccountID :participantAccountIDs[0]));
return;
}

What alternative solutions did you explore? (Optional)

N/A

[spcheema]

Proposed solution

Please re-state the problem that we are trying to solve in this issue.

It must show the detail of the user's profile that assigns the task

What is the root cause of that problem?

The header is showing details of the task creator but on clicking it is supposed to show the creator profile but it's showing the assignee one instead. The reason being for task-type reports "type": "task", participantAccountIDshold the task assignee information. On selecting a task report from LHN, it shows the correct avatar of the task owner but participantAccountID is used to navigate to the profile page. That's why it's showing assignee profile details, not the task owner.

What changes do you think we should make in order to solve the problem?

In the Slack discussion, it's decided to show the task detail page https://expensify.slack.com/archives/C01GTK53T8Q/p1691426870537099?thread_ts=1691334974.136469&cid=C01GTK53T8Q

The following are the changes required:

• Extend the following condition to include the task reports to show the task detail page

App/src/libs/ReportUtils.js

Line 1381 in dc32700

if (isChatRoom(report) || isPolicyExpenseChat(report) || isChatThread(report)) {

//   update dated code
if (isTaskReport(report) || isChatRoom(report) || isPolicyExpenseChat(report) || isChatThread(report)) {

• Show task name as title by setting shouldUseFullTitle false on ReportDetailsPage DisplayNames component

shouldUseFullTitle={!shouldDisableSettings || ReportUtils.isTaskReport(props.report)}

• Extend the below condition to display members' page title as members
  

  App/src/pages/ReportParticipantsPage.js

  Line 97 in dc32700

  ReportUtils.isChatRoom(props.report) || ReportUtils.isPolicyExpenseChat(props.report) || ReportUtils.isChatThread(props.report)

<HeaderWithBackButton
    title={props.translate(
        ReportUtils.isTaskReport(props.report) || ReportUtils.isChatRoom(props.report) || ReportUtils.isPolicyExpenseChat(props.report) || ReportUtils.isChatThread(props.report)
            ? 'common.members'
            : 'common.details',
    )}
/>

What alternative solutions did you explore? (Optional)

N/A

[hnkuanx]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When task header is clicked, the profile page of the assignee is shown.

Note: The reported behavior is actually reproducible as long as user click on the task header row, it is not specific to clicking on avatar.

What is the root cause of that problem?

The avatar itself is actually howerable but not pressable.

However the HeaderView rendered is wrapping the whole header row with PressableWithoutFeedback having onPress defined

App/src/pages/home/HeaderView.js

Line 165 in f9d760f

onPress={() => ReportUtils.navigateToDetailsPage(props.report)}

That is the reason the whole header row is pressable.

When user are clicking on the report header row (not just avatar!), the appropriate behaviour is to show the report detail page (similar to chat thread) instead of anyone's user profile.

Hence, Navigation.navigate(ROUTES.getReportDetailsRoute(report.reportID)); in

App/src/libs/ReportUtils.js

Lines 1446 to 1449 in f9d760f

	if (isChatRoom(report) || isPolicyExpenseChat(report) || isChatThread(report)) {
	Navigation.navigate(ROUTES.getReportDetailsRoute(report.reportID));
	return;
	}

is the behaviour we need, however when a task report is being opened, the IF condition returns false.

It fallbacks to the next IF condition

App/src/libs/ReportUtils.js

Lines 1450 to 1453 in f9d760f

	if (participantAccountIDs.length === 1) {
	Navigation.navigate(ROUTES.getProfileRoute(participantAccountIDs[0]));
	return;
	}

which causes it to incorrectly route user to the participant (assignee) profile page.

What changes do you think we should make in order to solve the problem?

1. Route user to the task report detail page when task report header is clicked.

By adding additional OR condition isTaskReport(report) into

App/src/libs/ReportUtils.js

Line 1381 in dc32700

if (isChatRoom(report) || isPolicyExpenseChat(report) || isChatThread(report)) {

2. Update task report detail page title to match the task full title

By changing

App/src/pages/ReportDetailsPage.js

Line 64 in 2ce4328

const shouldUseFullTitle = !shouldDisableSettings;

to

    const isTaskReport = useMemo(() => ReportUtils.isTaskReport(props.report), [props.report]);
    const shouldUseFullTitle = !shouldDisableSettings || isTaskReport;;

3. Update task report detail page > "Members" to show "Members" header instead of "Details", in order to be consistent with Thread Chat detail page

By adding additional OR condition ReportUtils.isTaskReport(props.report) into

App/src/pages/ReportParticipantsPage.js

Line 100 in 2ce4328

ReportUtils.isChatRoom(props.report) || ReportUtils.isPolicyExpenseChat(props.report) || ReportUtils.isChatThread(props.report)

Results:

Screen.Recording.2023-08-08.at.11.59.14.AM.mov

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

It must show the detail of the user's profile that assigns the task

What is the root cause of that problem?

The avatar of task report is the creator of the task, but in navigateToDetailsPage function, we redirect to profile page of participant of task report that is assignee

App/src/libs/ReportUtils.js

Lines 1450 to 1453 in 591dd1a

	if (participantAccountIDs.length === 1) {
	Navigation.navigate(ROUTES.getProfileRoute(participantAccountIDs[0]));
	return;
	}

What changes do you think we should make in order to solve the problem?

1. In here we should navigate to detail page if the report is task report

if (isChatRoom(report) || isPolicyExpenseChat(report) || isChatThread(report) || isTaskReport(report))

App/src/libs/ReportUtils.js

Lines 1446 to 1448 in 591dd1a

	if (isChatRoom(report) || isPolicyExpenseChat(report) || isChatThread(report)) {
	Navigation.navigate(ROUTES.getReportDetailsRoute(report.reportID));
	return;

2. In ReportDetailsPage, create a new variable isTaskReport to use on the page

const isTaskReport = useMemo(() => ReportUtils.isTaskReport(props.report), [props.report]);

2. In ReportDetailsPage, change shouldUseFullTitle condition to display the task report name in detail page

const shouldUseFullTitle = !shouldDisableSettings || isTaskReport;

App/src/pages/ReportDetailsPage.js

Line 64 in 2ce4328

const shouldUseFullTitle = !shouldDisableSettings;

3. We decided to display the second line to match the header in the main view so we should update chatRoomSubtitle to display the parent report name if the report is task report

const chatRoomSubtitle = useMemo(() => {
    if (isTaskReport) {
        return ReportUtils.getParentNavigationSubtitle(props.report).rootReportName;
    }
    return ReportUtils.getChatRoomSubtitle(props.report);
}, [props.report, policy]);

App/src/pages/ReportDetailsPage.js

Line 71 in 2ce4328

const chatRoomSubtitle = useMemo(() => ReportUtils.getChatRoomSubtitle(props.report), [props.report, policy]);

OPTIONAL: we can check if the current user is the creator or the assignee of the task we can change the second line to clickable and navigate the user to the parent report of the task.

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.08-08-2023.10.13.54.webm

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011911d675e889edb8

[melvin-bot]

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.