[HOLD for payment 2023-08-21] [$1000] Dev: Web - Edit popup menu hides the Paypal username while open first time

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Payments
2. Add Paypal payment method if not added
3. Click on Paypal username to edit or delete it

Expected Result:

Popup menu should not hide the Paypal username

Actual Result:

Popup menu hides the Paypal username while open first time(second time it's working fine)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.46-2
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-29.at.10.23.17.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690606718500609

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01acb5ccd86249930e
• Upwork Job ID: 1686327076369784832
• Last Price Increase: 2023-08-01
• Automatic offers:
• gadhiyamanan | Reporter | 25907181

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[huzaifa-99]

These repro steps worked for me

1. Make sure you have an account that has expensifyWallet permission i.e. it can add a debit card.
2. Go to settings -> click on payments -- notice when we go to the payments page there is a loading indicator
3. Now go back to settings page and once again go to payments page -- this time before the loading indicator disappears, click on the Paypal method.
4. Now you should see the popover hiding the Paypal method

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want the popover to not hide the Paypal payment method from the list

What is the root cause of that problem?

We are only recalculating the popover anchor position whenever the windowWidth changes here.

When we visit the payment list page, the API loads the latest balance and shows an activity indicator. If we click on the Paypal option during this time, the anchor position for the button will be set, and when the balance loads, the anchor position will remain the same, which hides the button.

What changes do you think we should make in order to solve the problem?

We should recalculate the anchor position whenever the balance starts/stops loading, by checking for the shouldShowLoadingSpinner value and adding it to this dependency array which would recalculate the anchor position whenever the balance starts/stops loading.

Result

Screen.Recording.2023-07-31.at.2.52.26.AM.mov

What alternative solutions did you explore? (Optional)

We could show a default balance instead of a loading indicator (which should have the same height) and the popover will be in the correct position even after the balance loads. For this we would have to clean up this condition to not show the loader.

Result

Screen.Recording.2023-07-31.at.2.49.42.AM.mov

[zanyrenney]

Thanks! Triaging this now.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01acb5ccd86249930e

[melvin-bot]

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.