[HOLD for payment 2023-08-17] [$1000] Completed task gets re-indexed if edited.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a task
2. Set to completed
3. Open task report and write something & watch the sidebar

Expected Result:

Completed task should not be reindex and should not move to top to the report list or if it has to move up then it should persist its index.

Actual Result:

Completed tasks moves to top while writing something in composer and gets back to its position if the message is sent.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.47-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

completed_task_reindexing.mp4

Recording.1403.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Krishna2323
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690436338235719

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ffb623af5dcd64cc
• Upwork Job ID: 1687217514400518144
• Last Price Increase: 2023-08-03
• Automatic offers:
• dukenv0307 | Contributor | 25999076

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[niteshletxsoft]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Completed task should not be reindex and should not move to top to the report list or if it has to move up then it should persist its index.

What is the root cause of that problem?

The root cause of this issue is the ordering of the report ID's based on their status and when the completed task has a draft comment, According to the current logic all draft report comes on the top.

App/src/libs/SidebarUtils.js

Lines 142 to 145 in 62622e9

	if (report.hasDraft) {
	draftReports.push(report);
	return;
	}

 if (report.hasDraft) {
      draftReports.push(report);
      return;
  }

This is the part of the code, which is causing the current issue.

What changes do you think we should make in order to solve the problem?

The actual solution to this issue is to keep the Completed task at their position even if the task has a draft comment.

We can check if this REPORT is a task and completed one, We will not put the REPORT in the draftReports array.

// The completed tasks should not move the position when have a draft
if (report.hasDraft && !(ReportUtils.isTaskReport(report) && ReportUtils.isCompletedTaskReport(report))) {
    draftReports.push(report);
    return;
}

As per the another half comment of the issue by the reporter "if it has to move up then it should persist its index."
We can not update the completed task position on new comments because this will conflict with the logic of archivedReports, which keeps the completed task at the bottom of the list.

What alternative solutions did you explore? (Optional)

N/A

[dukenv0307]

Not a bug, we prioritize the draft report on LHN

[twisterdotcom]

I agree, this is intentional. Not a bug.

[thienlnam]

I had the same initial view but in the video, it looks like after you send the message it is reverting it’s position which is the bug here. I agree it reindexing while in draft state is correct, but it seems like after the message is sent and it is no longer in draft state it should stay at the top

[twisterdotcom]

Hmmm, yes I haven't not used focus mode for a long time. I'll retest this.

[niteshletxsoft]

Yes, You are right @thienlnam. either the completed task should change the position on draft and keep the position after sending the message or should not change the position when has the draft message.
As shown in the bug, It changes the position when has the draft message and come back to original position when message is sent.

According to me, It should not come to top position with draft message as the task has been completed and that's the solution i have provided.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Completed tasks move to the top while writing something in Composer and get back to its position if the message is sent.

What is the root cause of that problem?

• The order report in LHN is calculated based on this line of code:

App/src/libs/SidebarUtils.js

Line 176 in 751d797

return _.pluck([].concat(pinnedReports).concat(outstandingIOUReports).concat(draftReports).concat(nonArchivedReports).concat(archivedReports), 'reportID');

• Then, the proper order in LHN will be
  Pinned Report -> outstandingIOU Reports -> Draft Reports -> Non Archived Reports -> Archived Reports

• In the current code, when a task is marked as completed, it will be pushed to the Archived Reports ( last position in the array of reports )

App/src/libs/SidebarUtils.js

Lines 152 to 155 in 751d797

	if (ReportUtils.isTaskReport(report) && ReportUtils.isCompletedTaskReport(report)) {
	archivedReports.push(report);
	return;
	}

• When creating a draft comment, it will be marked as Draft Reports ( the 3rd position )
• After the comment was sent, that report will be marked as Archived Reports again, as a result, it will be re-index and moved to the end of the report array in LHN. That's why we see the re-index issue.

What changes do you think we should make in order to solve the problem?

I think we should not consider a completed task as a Archived report but Non Archived Report instead. Since as I see in the UI. An archived report always has two characteristics

1. Having ( archived ) text next to it's name
2. No new comment are allowed

Therefore, after marking a completed task as non archived report, the after adding a new comment, completed tasks will stay on top in LHN

Result:

Screen.Recording.2023-08-02.at.17.18.48.mov

What alternative solutions did you explore? (Optional)

[dukenv0307]

@thienlnam Completed tasks are initially marked as Archived Report in this PR files https://github.com/Expensify/App/pull/18931/files