[$1000] Web - Country search input is cleared/reset when updating language on another device

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to any account
2. Go to Settings -> Profile -> Persona details -> Home address -> Country
3. Type any text to search a country
4. Go to another device, login same account
5. Change to another language on this device

Expected Result:

Country search input should be remain current search text when updating language on another device

Actual Result:

Country search input is cleared/reset when updating language on another device

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.47-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-28.at.21.48.37.mov

Recording.3990.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hoangzinh
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690556043839129

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016ec8ed64c16cfa11
• Upwork Job ID: 1694407216392552448
• Last Price Increase: 2023-08-23

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal by: @hoangzinh
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690556043839129

Proposal

Please re-state the problem that we are trying to solve in this issue.

Country search input is cleared/reset when updating language on another device

What is the root cause of that problem?

In the CountryPicker, we have a useEffect that reset the search text value when allCountries is changed. allCountries is changed when preferred language changed => when preferred language changed it reset the search text value, in this case it will reset to an empty string.

App/src/components/CountryPicker/index.js

Lines 38 to 40 in 28644a5

	useEffect(() => {
	setSearchValue(lodashGet(allCountries, value, ''));
	}, [value, allCountries]);

What changes do you think we should make in order to solve the problem?

I guess the useEffect above is used to set search text value when props.value is changed, then it will be used in the CountrySelectorModal
So I think we can remove the useEffect above and call set search text value with props.value in the show picker modal callback here

App/src/components/CountryPicker/index.js

Lines 42 to 44 in 28644a5

	const showPickerModal = () => {
	setIsPickerVisible(true);
	};

[alexpensify]

Not overdue - I was assigned over the weekend and will test soon.

[alexpensify]

There are some upcoming changes to the Country selector. I'm going to put it on hold to confirm if this behavior still happens when the update goes to production.

[hoangzinh]

@alexpensify could you point to the PR or GH Issue about those changes? Thanks

[alexpensify]

I believe the options will become dropdown following this update: #22018