[HOLD for payment 2023-08-21] [$1000] Web -Pointer cursor is displayed on send button even when compose box is empty

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report and hover on send button

Expected Result:

'not-allowed' cursor should be displayed on send button when there is no text in compose box

Actual Result:

Pointer cursor is displayed on send button even when there is no text in compose box

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.47-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

pointer.cursor.displayed.on.send.button.mp4

Recording.3987.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690618580440309

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fb9c3994ff691de4
• Upwork Job ID: 1685975218636345344
• Last Price Increase: 2023-07-31
• Automatic offers:
• dhanashree-sawant | Reporter | 25955399
• Nodebrute | Contributor | 25990051

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @PauloGasparSv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[c3024]

Edited as the earlier RCA was incorrect

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pointer is shown on Send button when the compose box is empty.

What is the root cause of that problem?

PR 22227 removed the disabled prop of Pressable and added it to the Tap. So there is default pointer for Pressable at all times

What changes do you think we should make in order to solve the problem?

We can use

pointerEvents = {this.state.isCommentEmpty || isBlockedFromConcierge || this.props.disabled || hasExceededMaxCommentLength ? 'none' : 'auto'}
                                    

on the Pressable.
or add to style,

{cursor: this.state.isCommentEmpty || isBlockedFromConcierge || this.props.disabled || hasExceededMaxCommentLength ? "not-allowed" : 'auto'}

and conditionally show the tooltip for the send button.

What alternative solutions did you explore? (Optional)

[Beamanator]

@c3024 that looks exactly why this is failing 👍

Do you have a chance to put up a PR quickly?

[c3024]

Yes, will make it right away.

[Beamanator]

Actually it looks like disabled was removed here: #22227