[HOLD for payment 2023-08-16] [$1000] mweb - Conversation - Login field is focused when sign out in offline mode

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to NewDot
2. Disable the internet connection
3. Tap on a few chats in LHN
4. Tap Settings
5. Tap Sign out
6. Enable the internet connection

Expected Result:

When Login page appear the login field should not be focused (cursor should not be shown on the input field)

Actual Result:

The login field is focused (cursor is shown on the input field)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6143968_issue.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012346a785d1fce53c
• Upwork Job ID: 1685011419766251520
• Last Price Increase: 2023-07-28
• Automatic offers:
• hoangzinh | Contributor | 25890078

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Login field is focused when sign out in offline mode

What is the root cause of that problem?

In LoginForm, we automatically focus the input on mount regardless of network status.

What changes do you think we should make in order to solve the problem?

We should check that this.props.network.isOffline is false before focusing the input through input.current.focus() in LoginForm.

What alternative solutions did you explore? (Optional)

We can disable the input when the user is offline.

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Conversation - Login field is focused when sign out on touchable devices

What is the root cause of that problem?

I think it's regression from this PR #22224. Previously, if we're using touchable devices, the login input is only focused when the login form is visible again https://github.com/Expensify/App/pull/22224/files#diff-e51fb1efdb0fbb2f3f94e412595749301118191aaf0522067a137917935009abL91-L99 (mean if we're back from validate code page). But now, with above PR, we haven't checked this condition, we always focus when useEffect is triggered, in this case it's trigger when inputRef is assigned => It's root cause of In touchable devices, App focus in login field after sign out

App/src/pages/signin/LoginForm.js

Lines 165 to 173 in bdd8e51

	useEffect(() => {
	if (props.blurOnSubmit) {
	input.current.blur();
	}
	if (!input.current || !props.isVisible) {
	return;
	}
	input.current.focus();
	}, [props.blurOnSubmit, props.isVisible, input]);

What changes do you think we should make in order to solve the problem?

We can use our custom hook usePrevious to store previous value of props.isVisible then compare like previous change. Only focus if the form is re-visible again in this useEffect (!previousIsVisible && props.isVisible)

App/src/pages/signin/LoginForm.js

Lines 165 to 173 in bdd8e51

	useEffect(() => {
	if (props.blurOnSubmit) {
	input.current.blur();
	}
	if (!input.current || !props.isVisible) {
	return;
	}
	input.current.focus();
	}, [props.blurOnSubmit, props.isVisible, input]);

[CortneyOfstad]

Was able to recreate — getting eyes on this

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012346a785d1fce53c

[melvin-bot]

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)