[HOLD for payment 2023-09-06] [$1000] Android - Sign In - Get started below page is cut off if switch tab than come back to app & start typing

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the login page
2. Tap on the email field to open the soft keyboard
3. Scroll down and click on any link (Expense report in my case)
4. Switch back to the login page

Expected Result:

When start typing I should see the complete login page without any cut offs

Actual Result:

When start typing after Step 4 the login page is not scrolled to the top - "Get started below" page is cut off

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.46-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6142828_az_recorder_20230726_223014.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010bbebff5900a82ee
• Upwork Job ID: 1686501797532385280
• Last Price Increase: 2023-08-01
• Automatic offers:
• mollfpr | Reviewer | 25998264
• joh42 | Contributor | 25998265

[melvin-bot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Sign In - Get started below page is cut off if switch tab than come back to app & start typing

What is the root cause of that problem?

we don't have the logic to scroll top if user start typing. On mweb platform, the input will be shown when users start typing but the whole get started below page is not shown

What changes do you think we should make in order to solve the problem?

• In SignInPageLayout, we have scrollPageToTop function, so we can use it in SignInPage by changing props.children to {props.children(scrollPageToTop)}

Change

App/src/pages/signin/SignInPage.js

Lines 147 to 155 in f8bc305

	{/* LoginForm must use the isVisible prop. This keeps it mounted, but visually hidden
	so that password managers can access the values. Conditionally rendering this component will break this feature. */}
	<LoginForm
	isVisible={shouldShowLoginForm}
	blurOnSubmit={account.validated === false}
	/>
	{shouldShowValidateCodeForm && <ValidateCodeForm />}
	{shouldShowUnlinkLoginForm && <UnlinkLoginForm />}
	{shouldShowEmailDeliveryFailurePage && <EmailDeliveryFailurePage />}

to

(scrollToTop) => (
<>
    <LoginForm
        scrollPageToTop = {scrollPageToTop}
    />
...
</>
)

• Finally In LoginForm we call scrollPageToTop in onTextInput function.

In order to prevent calling scrollPageToTop too many times we can check the scrollTop is 0 or not. If scrollTop is 0 we don't need to call scrollPageToTop

What alternative solutions did you explore? (Optional)

We can use useImperativeHandle to allow SignInPage to use scrollPageToTop from SignInPageLayout

[melvin-bot]

@tjferriss Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010bbebff5900a82ee

[melvin-bot]

Current assignee @tjferriss is eligible for the External assigner, not assigning anyone new.

[tjferriss]

Reproducible.