[$1000] Web - Inconsistent parsing behavior on copying and editing an invalid URL with HTTP protocol

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open https://staging.new.expensify.com/
2. Send this message to a chat : http://_
3. Wait for a while and try to edit the message with "Edit comment". Examine the message parsed
4. Copy the message with using "Copy to Clipboard" and paste it on the message textbox. Examine the message displayed in the textbox

Expected Result:

Either the URL isn't parsed at all (since it doesn't have the valid TLD and isn't a reserved name (like localhost for example)), or the behavior on both editing and upon copying should be consistent

Actual Result:

he message before edit and copied message is different (Message before edit message shown as "http://_", copied message shown as "http://_")

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.46.7
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2nd.-.Invalid.URL.Parsing.mp4

Expensify/Expensify Issue URL:
Issue reported by: @kerupuksambel
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689596021560619

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e96ccfaa92b9a019
• Upwork Job ID: 1683921325168218112
• Last Price Increase: 2023-08-15

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent parsing behavior on copying and editing an invalid URL with HTTP protocol

What is the root cause of that problem?

The frontend recognizes the invalid URL, however subsequently it gets replaced by the backend.
There is an inconsistency in what is considered a valid URL between the frontend and backend.

What changes do you think we should make in order to solve the problem?

We should correct the regular expression for detecting URLs to make it consistent with the backend.

What alternative solutions did you explore? (Optional)

[omarirfan68]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Inconsistent parsing behavior on copying and editing an invalid URL with HTTP protocol

What is the root cause of that problem?

The root cause of the problem is to add there regular expression like that

function ChatMessage({ message }) {
  const isValidURL = /^(?:(?:https?|ftp):\/\/)?[\w-]+(?:\.[\w-]+)+(?:[\w.,@?^=%&:/~+#-]*[\w@?^=%&/~+#-])?$/i.test(message);

  return (
    <div>
      {isValidURL ? (
        <a href={message} target="_blank" rel="noopener noreferrer">
          {message}
        </a>
      ) : (
        message
      )}
    </div>
  );
}

What changes do you think we should make in order to solve the problem?

We can make changes in ReportActionCompose.js to make it work properly after adding a regular expression to check the link!

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e96ccfaa92b9a019

[melvin-bot]

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.