[HOLD for payment 2023-08-24] [$1000] Web - Pressing space key applies focus to composer & scrolls comments at the same time

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a report that has multiple, scrollable comments
2. Scroll to the bottom of comments
3. Remove focus from the main composer
4. Press 'Space' key

Expected Result:

The composer should not be focused and the report page should be scrolled.

Actual Result:

Composer is focused & report is scrolled making the function of space key less predictable.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-07-24.13-57-13.mp4

Recording.3885.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690196594809449

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0150e7ff18d1f62eb0
• Upwork Job ID: 1683892863293607936
• Last Price Increase: 2023-07-25
• Automatic offers:
• samh-nl | Contributor | 25928554
• Natnael-guchima | Reporter | 25928556

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing space in a report applies focus to the composer and scrolls comments.

What is the root cause of that problem?

The focusComposerOnKeyPress function (ReportActionCompose.js) is used to place the focus in the composer when a key press event occurs. However, the default behavior of scrolling is still continued.

What changes do you think we should make in order to solve the problem?

To prevent focusing the composer when space is pressed, we can add a condition to focusComposerOnKeyPress similar to how other keys such as Enter and Shift are ignored.

App/src/pages/home/report/ReportActionCompose.js

Lines 721 to 724 in c6dd3d9

	// If the key pressed is non-character keys like Enter, Shift, ... do not focus
	if (e.key.length > 1) {
	return;
	}

What alternative solutions did you explore? (Optional)

Alternatively, if it's desired that scrolling is blocked but the focusing behavior is maintained, we should add e.preventDefault() right before this.focus() in the focusComposerOnKeyPress function.

App/src/pages/home/report/ReportActionCompose.js

Line 736 in c6dd3d9

this.focus();

[trjExpensify]

@mountiny @JmillsExpensify I found this somewhat similar issue when looking into this one. It's similar in that it's an issue with clicking the space bar. In terms of expected behaviour, I would think we scroll the chat page and don't focus the composer in this case here. Would you agree with that?

[mountiny]

@trjExpensify I agree the expected behaviour should be no focus and just scroll down

[trjExpensify]

Cool, updating the OP's expected behaviour to make that clear. 👍 Moving on!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0150e7ff18d1f62eb0

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)