[HOLD for payment 2024-06-13] [$500] Infinite loading spinner when trying to open a link to an Image that is in a room I have no access to.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat room and send an image
2. Open the image and copy the link of the image
3. Login as a user who DOESN'T have access to that room
4. Navigate to the link you copied

Expected Result:

An error page should appear for the user that he doesn't have access to that attachment because he doesn't have access to its room.

Actual Result:

An infinite spinner for the attachment loading appears, and nothing to tell the user that he can't open that attachment.
After closing it, the user got "Hmm... it's not here You don't have access to this chat'', and if he navigate to the image link again he got the "Uh-oh, something went wrong!" page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.19-07-23.21_28_35.webm

Recording.1317.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Ahmed-Abdella
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689814964693879

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01440acd5fcf557a24
• Upwork Job ID: 1683569021878947840
• Last Price Increase: 2024-05-08
• Automatic offers:
• Ahmed-Abdella | Contributor | 0

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Infinite loading spinner when trying to open a link to an Image that is in a room I have no access to.

What is the root cause of that problem?

For the attachment that have no access to, app pass empty file.name prop to AttachmentView.
But in AttachmentView, there is not check whether file.name is empty.
So the infinite loading spinner is shown.

What changes do you think we should make in order to solve the problem?

We should add checking whether file.name is empty in AttachmentView component, and if is empty, return NotFoundView.

function AttachmentView(props) {
    ...
    if (props.file.name === '') {
        return <NotFoundPage />;
    }
    ...

What alternative solutions did you explore? (Optional)

None.

[greg-schroeder]

Will review

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01440acd5fcf557a24

[melvin-bot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.