[HOLD for payment 2023-08-28] [$1000] Web - Can create a task on a room archived

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a WS
2. Go to an admin room
3. Delete above WS , observed nothing can be done with WS admin room has been deleted
4. Click FAB => Assign task
5. Enter title => Next
6. Click => share somewhere section , observed that the admin room was archived before
7. Select admin room was archived
8. Go back admin room on LHN, observe that the task has been created

Expected Result:

Cannot create task in archived room

Actual Result:

Can create task in archived room

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.43-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-21.at.00.53.44.mov

Recording.3803.mp4

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689876140321539

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e9e5e6cb40b0c193
• Upwork Job ID: 1683971766866116608
• Last Price Increase: 2023-08-08
• Automatic offers:
• aimane-chnaif | Reviewer | 26071849
• Nikhil-Vats | Contributor | 26071851
• namhihi237 | Reporter | 26071855

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

by: @namhihi237

Please re-state the problem that we are trying to solve in this issue.

Cannot create a task in an archived room

What is the root cause of that problem?

• When in the step of selecting Share somewhere, we still list archived rooms in here and here
• The backend hasn't checked if the room is archived.

What changes do you think we should make in order to solve the problem?

We have 2 issues to update:

• Filter archived rooms like this:

_.filter(recentReports ,report => !report.isArchivedRoom)

• Backend should be check not allowed with the archived room.

What alternative solutions did you explore? (Optional)

N/A

Proposal

Please re-state the problem that we are trying to solve in this issue.

Can create a task on a room archived

What is the root cause of that problem?

We don't have any logic to filter archived room on share somewhere list

What changes do you think we should make in order to solve the problem?

we should introduce new param on getOptions function called includeArchivedRoom (default value is true)

App/src/libs/OptionsListUtils.js

Lines 976 to 977 in 2c5dd69

	function getShareDestinationOptions(reports, personalDetails, betas = [], searchValue = '', selectedOptions = [], excludeLogins = [], includeOwnedWorkspaceChats = true) {
	return getOptions(reports, personalDetails, {

And we will pass includeArchivedRoom: false in getShareDestinationOptions function

In getOptions function

App/src/libs/OptionsListUtils.js

Line 655 in 2c5dd69

const filteredReports = _.filter(reports, (report) => ReportUtils.shouldReportBeInOptionList(report, Navigation.getTopmostReportId(), false, iouReports, betas, policies));

we should add logic to filter archivedRoom if includeArchivedRoom is true

const filteredReports = _.filter(reports, (report) => ReportUtils.shouldReportBeInOptionList(report, Navigation.getTopmostReportId(), false, iouReports, betas, policies))  
            && (includeArchivedRoom ? true : !ReportUtils.isArchivedRoom(report))

What alternative solutions did you explore? (Optional)

[Nikhil-Vats]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Users can share a task in rooms/chats that couldn't be created on backend due to error.

What is the root cause of that problem?

In TaskShareDestinationSelectorModal, we are filtering the reports using the following code -

App/src/pages/tasks/TaskShareDestinationSelectorModal.js

Lines 49 to 58 in c80947c

	const filteredReports = useMemo(() => {
	const reports = {};
	_.keys(props.reports).forEach((reportKey) => {
	if (
	!ReportUtils.isAllowedToComment(props.reports[reportKey]) ||
	ReportUtils.isArchivedRoom(props.reports[reportKey]) ||
	ReportUtils.isExpensifyOnlyParticipantInReport(props.reports[reportKey])
	) {
	return;
	}

We filter reports where user is not allowed to comment or if report is archived or report has only 1 participant which is an expensify account.

What changes do you think we should make in order to solve the problem?

1. We have another function in ReportUtils called shouldHideComposer which returns true if report is archived, user is not allowed to comment or report has errors -
   

   App/src/libs/ReportUtils.js

   Lines 2789 to 2791 in 591dd1a

   	function shouldHideComposer(report, reportErrors) {
   	return isArchivedRoom(report) || !_.isEmpty(reportErrors) || !isAllowedToComment(report) || isAnonymousUser;
   	}

   
   We should use shouldHideComposer along with isExpensifyOnlyParticipantInReport in TaskShareDestinationSelectorModal. shouldHideComposer checks for permissions and archived reports so we can remove them,
   We need to change the if block on line 54 to -

    // we can get reportErrors from this function which only returns error where report is failed to be created (see below) -
    const {addWorkspaceRoomOrChatErrors} = ReportUtils.getReportOfflinePendingActionAndErrors(props.reports[reportKey]);
    if (ReportUtils.shouldHideComposer(props.reports[reportKey], addWorkspaceRoomOrChatErrors) || ReportUtils.isExpensifyOnlyParticipantInReport(props.reports[reportKey])) {
         return;
     }

   App/src/libs/ReportUtils.js

   Line 2813 in 591dd1a

   const addWorkspaceRoomOrChatErrors = lodashGet(report, 'errorFields.addWorkspaceRoom') || lodashGet(report, 'errorFields.createChat');

2. For the second related issue where archived rooms allows unauthorized task editing - It was confirmed here by Jack that users should be able to edit the task in archived room so this is no longer a bug.

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@twisterdotcom Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kbecciv]

Archived Room Allows Unauthorized Task Editing and Completion

Action Performed:

1 Go to the archived room and locate the old task
2 Click on the task thread
3 Mark it has incomplete
4 Change the title and verify you are successful
5 Mark it has complete and reopen it multiple times
6 Observe you are getting reopened and completed message

Expected Result:

Unable to edit task

Actual Result:

Successful in editing title, closing and reopening tasks in an archived room

Version Number: 1.3.45.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

archieve-.task.mp4

Recording.3909.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690250190898259

[thienlnam]

Had applause add this bug here since we should make sure we handle these edge cases in this issue as well

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e9e5e6cb40b0c193