[HOLD for payment 2023-09-06] [$2000] Web - The backtick is outside the code block when sending a message with two backticks

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Send a text wrapped in two backticks

Expected Result:

Backtick should be in the code block

Actual Result:

One Backtick is out of the code block

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.43-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Test79_Backtick-1.mp4

Recording.3809.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689891927706399

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f54ca2df0a387770
• Upwork Job ID: 1684220588166258688
• Last Price Increase: 2023-08-09
• Automatic offers:
• abdulrahuman5196 | Reviewer | 26116411
• daveSeife | Reporter | 26116415

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Using two backticks leads to an incorrect processing of a code block.

What is the root cause of that problem?

The regular expression that is used for recognizing code blocks uses 'lazy' matching, as opposed to 'greedy' matching which is required in this case.

https://github.com/Expensify/expensify-common/blob/fea1a755affabdbb8b6d7c5b754241849124f488/lib/ExpensiMark.js#L45-L52

What changes do you think we should make in order to solve the problem?

The last question mark inside (.*?\S.*?) should be removed to get the desired result.

Lastly, we could check for similar problems in the regular expressions of other markdown processing rules, such as the triple backtick block.

What alternative solutions did you explore? (Optional)

Option 1. Expand the regular expression to include an optional second backtick.
Option 2. Only expand the matching if the subsequent backtick(s) directly follow each other, i.e. without other characters in between. This involves adding (`)* to the regular expression (see below) and changing $3 to $4.

regex: /(\B|_|)&#x60;(.*?\S.*?(&#x60;)*)&#x60;(\B|_|)(?![^<]*<\/pre>)/g,
replacement: '$1<code>$2</code>$4',

Edit: Updated proposal

[melvin-bot]

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

Asking about this here: https://expensify.slack.com/archives/C01GTK53T8Q/p1690384105813549

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f54ca2df0a387770

[melvin-bot]

Current assignee @muttmuure is eligible for the External assigner, not assigning anyone new.