[$1000] Input loses focus when using keyboard shortcut

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Press CTRL + K to open the search panel
2. Press CTRL + J and then CTRL + K and notice the input filed is still focused
3. Press CTRL + Shift + K to open the new group side panel
4. Press CTRL + J and then CTRL + Shift + K and notice the input filed is still focused
5. Press CTRL + K and then CTRL + J and then CTRL + K and notice the input field

Expected Result:

Input field should be focused just as before

Actual Result:

Input field loses focus if user presses CTRL + K then CTRL + Shift + K then CTRL + K

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.43-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-07-19.12.33.34.mp4

Recording.1303.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689759489738269

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011bee8d7fcd40b4bd
• Upwork Job ID: 1683864787973197824
• Last Price Increase: 2023-07-25

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Input loses focus when using keyboard shortcut

What is the root cause of that problem?

When we go to the new group page from the search page, textInput of the search page is blurry. And then when we go back, search page is not unmounted and we don't have the check to focus textInput again when the page is refocused

What changes do you think we should make in order to solve the problem?

In BaseOptionsSelector, we can add a check componentDidUpdate function to focus textInput again when the page is focused

if (!prevProps.isFocused && this.props.isFocused) {
    if (this.props.shouldShowTextInput) {
        if (this.props.shouldDelayFocus) {
            this.focusTimeout = setTimeout(() => this.textInput.focus(), CONST.ANIMATED_TRANSITION);
        } else {
            this.textInput.focus();
        }
    }
}

App/src/components/OptionsSelector/BaseOptionsSelector.js

Line 127 in e87f2eb

componentDidUpdate(prevProps) {

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.20-07-2023.16.36.33.webm

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011bee8d7fcd40b4bd

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)