[HOLD for payment 2023-08-17] [$1000] Update Task title/description/assignee when offline is not grey out

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any Task report
2. Turn off network
3. Update task title/description/assignee

Expected Result:

Task title/description/assignee should be grey out when update in offline mode

Actual Result:

Task title/description/assignee is not grey out

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.43-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-17.at.23.20.26.mov

Expensify/Expensify Issue URL:
Issue reported by: @hoangzinh
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689611035906189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0138286787014f7dd4
• Upwork Job ID: 1682219760636948480
2023-07-21
• Automatic offers:
• mollfpr | Reviewer | 25750552
• | | 0
• hoangzinh | Reporter | 25750553

[melvin-bot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Updated task actions are not greyed out when offline.

What is the root cause of that problem?

We're not wrapping the items inside the TaskView component inside a OfflineWithFeedback component.

What changes do you think we should make in order to solve the problem?

Wrap the items inside TaskView inside OfflineWithFeedback. In order for this to work, we need to make sure that the edited fields are correctly represented in the pendingFields section of the report. To do this, we can add the appropriate pending fields while setting the optimistic data in editTaskAndNavigate and createTaskAndNavigate function.

To demonstrate the approach, I'll just show the steps needed to implement the greying out of the task title on edit.

1. Replace the fragment here with:

<OfflineWithFeedback
    onClose={() => {}}
    pendingAction={props.report.pendingFields.reportName}
    errors={null}
    errorRowStyles={[styles.ml10, styles.mr2]}
>
.
.
.
</OfflineWithFeedback>

2. Add the following pendingFields in the report when editing a task here.

pendingFields: {
    ...title && {reportName: 'update'},
},

3. Set the pendingFields as {} in the success data.

Result

What alternative solutions did you explore? (Optional)

Instead of using OfflineWithFeedback component, we can just add a style that sets opacity to 0.5 if there is a pending field in the report.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0138286787014f7dd4

[melvin-bot]

Current assignee @tjferriss is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[tjferriss]

It actually looks like it's intended that we do not grey this out per #22907