[HOLD for payment 2023-08-03] [$1000] Web - Incorrect Redirection to Chat Page when Accessing /workspace/new-room URL

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log into any account and open any chat.
2. Change the URL in the browser to "https://staging.new.expensify.com/workspace/new-room" and press Enter.
3. Observe the page that is displayed.

Expected Result:

The ''Hmm... it's not here'' page should be displayed, indicating the user has attempted to access an inaccessible URL.

Actual Result:

The user is incorrectly redirected to the chat page, instead of being shown the ''Hmm... it's not here'' page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.40-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bug.12.mp4

Recording.3713.mp4

Expensify/Expensify Issue URL:
Issue reported by: @rayane-djouah
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689468456062279

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016da10a4664ea006b
• Upwork Job ID: 1681791241049214976
2023-07-19
• Automatic offers:
• | | 0
• Ollyws | Contributor | 25717033
• rayane-djouah | Reporter | 25717036

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Ollyws]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The user is re-directed to the chat when trying to access the inaccessible route /workspace/new-room

What is the root cause of that problem?

Here we just dismiss the modal if we don't have permission:

App/src/pages/workspace/WorkspaceNewRoomPage.js

Lines 132 to 142 in ab3d0e8

	useEffect(() => {
	if (Permissions.canUsePolicyRooms(props.betas) && workspaceOptions.length) {
	return;
	}
	Log.info('Not showing create Policy Room page since user is not on policy rooms beta');
	Navigation.dismissModal();
	}, [props.betas, workspaceOptions]);
	if (!Permissions.canUsePolicyRooms(props.betas) || !workspaceOptions.length) {
	return null;
	}

What changes do you think we should make in order to solve the problem?

We can remove this and instead wrap the content in FullPageNotFoundView using the same conditions as above in the shouldShow. This will display the Hmm it's not here page in the modal, which can then be dismissed by the user.

What alternative solutions did you explore? (Optional)

None

[jliexpensify]

Is this fixed on v1.3.42-24? @kbecciv please re-test this one!

Here's what I see:

[Ollyws]

@jliexpensify You seem to be using an account that has the rooms beta enabled. This can only be reproduced on an account that doesn't have access to the rooms beta (all new accounts don't have access by default, as far as I'm aware).

[rayane-d]

@jliexpensify it's still reproducible in latest staging. you just need to test with a new account.

2023-07-19.14-46-59.mp4

[jliexpensify]

@Ollyws and @rayane-djouah - thanks for letting me know!c I will re-test with a different account.

[jliexpensify]

I'm seeing slightly different behaviour - I get an archived chat room. But I agree: this is an issue.

2023-07-20_08-19-28.mp4