[$1000] Chat - App removes strikethrough formatting on copy and resend for code block

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Send strikethrough code block eg: Hello
4. Hover on message and click on copy to clipboard OR edit the message and copy the message
5. Send the copied message and observe that app removes strikethrough format from the code block

Expected Result:

App should keep the format of text same when we copy it to clipboard or copy from edit message and resend the message

Actual Result:

App does not keep the format of strikethrough on code block on copy to clipboard or copy from edit message and resend the message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.41-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

removes.strikethrough.on.copy.and.resend.mp4

Recording.3706.mp4

Expensify/Expensify Issue URL:
Issue reported by: GH handle - @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689525870441879

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012fc66a9c82073e51
• Upwork Job ID: 1681045679677927424
• Last Price Increase: 2023-09-11

[eh2077]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App removes strikethrough formatting on copy and resend for code block.

What is the root cause of that problem?

The root cause of this issue is that we translate

~```test```~

to HTML

<del><pre>test</pre></del>

through strikethrough rule and the HTML is converted back to Markdown

~```
Hello
```
~

through htmlToMarkdownRules.

What changes do you think we should make in order to solve the problem?

To fix this issue, we can skip applying strikethrough rule if it contains pre tag, just like italic and bold rule. So, we can change this line to

replacement: (match, g1) => (g1.includes('<pre>') || this.containsNonPairTag(g1) ? match : `<del>${g1}</del>`),

By doing so, we won't apply strikethrough style for markdown input, like

~```test```~

So, copying and pasting comment will have consistent style, just like italic and bold syntax do.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[joekaufmanexpensify]

I can reproduce this. I don't think we're really "removing" the formatting though when copying the code block. It's just that when it's pasted, there's a space between the last ` and ~. If the space is removed before you send the message you copied, we do show the strikethrough.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012fc66a9c82073e51

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[parasharrajat]

I am checking the processing rules to determine the expected behaviour.