[HOLD for payment 2023-08-01] Incorrect payment type showing when expense report paid optimistically

[mountiny]

Problem

When Expense report is paid optimistically, the payment type is showing using ACH but it should say using Expensify. Additionally the report preview message in the LHN for the workspace chat says: paid $xx.xx elsewhere when it should also say using Expensify.

Coming from https://expensify.slack.com/archives/C02HWMSMZEC/p1689609649798459?thread_ts=1689251014.088399&cid=C02HWMSMZEC

Related to #21535 (comment)

Solution

Fix this incorrect optimistic data set

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d75f737d5f117249
• Upwork Job ID: 1680986431959179264
• Last Price Increase: 2023-07-17

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d75f737d5f117249

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @abdulrahuman5196 (Internal)

[twisterdotcom]

What is my job here as the BZ assignee? Now that most C+ are paid outside of Upwork, I kind of have nothing to do here.

[mountiny]

Not all C+ are for example @abdulrahuman5196 is not.

[sakluger]

I think #22958 is a duplicate. @mountiny could you verify? If so, I'll close the other one.