[HOLD for payment 2023-08-02] [HOLD for payment 2023-08-01] [$1000] Web - The first letter of the chat name is cut

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat with other user
2. add "/settings" to the address in address bar (like "https://new.expensify.com/r/4148003058225040/settings")
3. Open Room Name
4. Notice that name is "hat Report", first letter is cut

Expected Result:

he name should be the same as on previous page

Actual Result:

The first letter of the chat name is cut

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.40-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-07-17.10.00.20.mov

Recording.3686.mp4

Expensify/Expensify Issue URL:
Issue reported by: @alexxxwork
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689405309465269

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0196a1bf7800ad8925
• Upwork Job ID: 1680963664829435904
• Last Price Increase: 2023-07-17

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ginsuma]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room settings authorization.

What is the root cause of that problem?

We don't check user permission when accessing room settings and its menu (room name, who can post, welcome message) via deeplink.

What changes do you think we should make in order to solve the problem?

• ReportSettingsPage: we need to change shouldShow condition in FullPageNotFoundView. Currently, the condition is only whether it is empty or not. We should add the condition like below to avoid adding '/settings' after a report url such as DM chats, Concierge, Tasks and having access to settings. This is the condition to show Settings menu in ReportDetailsPage.
  

  App/src/pages/ReportDetailsPage.js

  Line 102 in ab3d0e8

  if (isPolicyExpenseChat || isChatRoom || isThread) {

• RoomNamePage (should be fixed from #21498), WriteCapabilityPage, ReportWelcomeMessagePage: we wrap them in FullPageNotFoundView and reuse the logic in RoomSettingPage to set shouldShow.

What alternative solutions did you explore? (Optional)

Currenty, I don't see anywhere to set notification preference for DM chats. If we need it in the future, we will show only notification item when navigating to DM chats settings.

[alexxxwork]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

The root cause is that we strip first letter of chat report name for all chats (rooms and ordinary chats) here:

App/src/libs/ReportUtils.js

Lines 1207 to 1210 in 67bac9d

	if (getChatType(report) === CONST.REPORT.CHAT_TYPE.DOMAIN_ALL) {
	// The domainAll rooms are just #domainName, so we ignore the prefix '#' to get the domainName
	return report.reportName.substring(1);
	}

What changes do you think we should make in order to solve the problem?

We can add a condition to check whether the first letter is "#" or not

What alternative solutions did you explore? (Optional)

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The first character of the name is removed in the Room name input.

What is the root cause of that problem?

In the TextInput component, the first character is stripped as it is assumed to be a room having a hashtag:

App/src/components/RoomNameInput/index.js

Line 71 in 25c8ae5

value={this.props.value.substring(1)} // Since the room name always starts with a prefix, we omit the first character to avoid displaying it twice.

However, this is not the case since it concerns a chat report. No check is currently in place to distinguish these situations.

What changes do you think we should make in order to solve the problem?

Option 1. Based on an empty value of report.chatType we can determine that this is not a room. In such situation, we should not strip the first character of the name.

Option 2. We should not be able to edit the "room name" in the first place, since it does not concern a room. Thus, in the Settings page, the Room name should be removed, renamed (for example: Chat name, with the name being the actual title, i.e. the participants) and/or made not clickable.

What alternative solutions did you explore? (Option)

N/A

[CortneyOfstad]

Was able to recreate so going to get eyes on this:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0196a1bf7800ad8925

[melvin-bot]

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.