[HOLD for payment 2023-08-10] [$1000] Mweb - "Deleted message" chat appears in chat list for pinned deleted threads

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to staging new dot
2. Go to any chat and long press on any message within the chat
3. Click on reply in thread and send a message in thread
4. Pin the thread using the pin icon at top right corner
5. Now delete the parent message in the thread
6. Go back to parent message and click on thread
7. Now delete the child message in the thread
8. Go back to chat and observe the thread has been removed
9. Go to chat list and observe that the deleted thread can be found pinned as "Deleted message" chat

Expected Result:

The deleted thread should also be removed

Actual Result:

The deleted thread remains in the chat list even after parent and child messages are both deleted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.41-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023_07_14_09_59_40.mp4

Screen_Recording_20230715_141340_Chrome.mp4

Expensify/Expensify Issue URL:
Issue reported by: @SofoniasN
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689361647727409

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01259a3effbfb36398
• Upwork Job ID: 1682395479803457536
2023-07-21
• Automatic offers:
• | | 0
• hoangzinh | Contributor | 25765217
• sofoniasN | Reporter | 25765220

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mweb - "Deleted message" chat appears in chat list for pinned deleted threads

What is the root cause of that problem?

We're checking in here, if our reports are pinned or hasDraft then added it to the list.

App/src/libs/ReportUtils.js

Lines 2127 to 2129 in 6e5b07c

	if (report.hasDraft || report.isPinned || hasOutstandingIOU(report, iouReports)) {
	return true;
	}

In this case, even our parent reportAction was deleted and not visible any more, we still show the child report because it's pinned.

What changes do you think we should make in order to solve the problem?

Add a condition in here to check, if our thread is empty and deleted, we shouldn't add it to the list even it has draft or pinned.

    const parentAction = ReportActionsUtils.getParentReportAction(report);

    if (isChatThread(report) && !ReportActionsUtils.hasCommentThread(parentAction) && !ReportActionsUtils.shouldReportActionBeVisible(parentAction)) {
        return false;
    }

or

    if (isChatThread(report) && !ReportActionsUtils.hasCommentThread(parentAction) && ReportActionsUtils.isDeletedAction(parentAction)) {
        return false;
    }

Incase we wanna keep the report if we have draft we can change the condition above, it depends on the expected requirements.

What alternative solutions did you explore? (Optional)

N/A

[alexpensify]

I was assigned over the weekend-- I will review it soon.

[alexpensify]

@fedirjh and @MonilBhavsar - Could I get feedback here? I see that @hungvu193 worked on the fix for #21103. @hungvu193 please add feedback too. I see the fixed issue was focused on web. To confirm, that fix does not take into account Mweb say for Chrome on Android? I'm trying to confirm this one isn't a dupe before assigning the external label. Thanks!

[fedirjh]

@alexpensify This issue doesn’t looks related to the PR @hungvu193 worked on. But I think this is a missed case from #21508 , cc @dangrous or @mananjadhav could you please add any feedbacks ?

• If a deleted parent doesn't have a thread anymore, hide it #22690

[alexpensify]

@fedirjh - thank you for pointing me in a better direction! I'll wait for @dangrous or @mananjadhav feedback before assigning the external label.

[dangrous]

@alexpensify This issue doesn’t looks related to the PR @hungvu193 worked on. But I think this is a missed case from #21508 , cc @dangrous or @mananjadhav could you please add any feedbacks ?

• If a deleted parent doesn't have a thread anymore, hide it #22690

Yep, I think this is a case we didn't think about when we changed the expected behavior in that issue. Not specifically a regression since I'm guessing this behavior would have happened before the change too. Should be a pretty easy fix though!