[HOLD for payment 2023-08-08] [$1000] Dev: Web - App crashes when trying to unlink secondary contact method

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a tab where account A is signed-in
2. Add secondary contact method B, and do not verify that contact method
3. Open a new window > Navigate to sign-in page
4. Enter secondary contact method B & click on the continue button
5. Click on 'unlink' button
6. Open email > copy 'validate link' > prefix the link localhost address > press enter

Expected Result:

App shouldn't crash & should unlink the secondary contact method

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.40-5
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-07-14.15-40-28.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689338260193289

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0125c02caca7cbee50
• Upwork Job ID: 1682413664782585856
2023-07-21
• Automatic offers:
• mollfpr | Reviewer | 25738337
• StevenKKC | Contributor | 25738338
• Natnael-guchima | Reporter | 25738340

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ygshbht]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In the current Expensify app, attempting to unlink a secondary contact method leads to an application crash. This unexpected behaviour is triggered under the condition that the secondary contact method is unverified. This issue is particularly associated with the process of secondary contact validation and de-linking.

What is the root cause of that problem?

Investigation points to the translate function, which is used to handle language-specific translations of phrase keys in the application. It appears that when this function doesn't find a phrase key in the language dictionaries, it throws an error that leads to the application crash.

What changes do you think we should make in order to solve the problem?

A more robust alternative is to utilize the translateIfPhraseKey function which, unlike translate, returns the original message when a matching phrase is not found, rather than throwing an error. This graceful degradation prevents the application from crashing due to an error thrown.

Moreover, the translateIfPhraseKey function seems specifically designed for situations where the phrase keys might be dynamic or potentially non-existent in the language dictionaries, thus making it a more resilient choice.

Therefore, by replacing the translate function with translateIfPhraseKey in the specific code path related to unlinking secondary contact methods, we can avoid this issue and improve the overall robustness of the application.

What alternative solutions did you explore? (Optional)

Alternatively, like others, if the message is pre-translated, we could directly display the message as received. This approach bypasses the application of the translate or translateIfPhraseKey functions for this scenario, streamlining the process and diminishing the possibility of an application crash.

Result:

Studio_Project_V1.mp4

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when trying to unlink secondary contact method.

What is the root cause of that problem?

If unlink secondary contact method, unlinkLogin function will be called.
In this function, set account.message Onyx data to the translated message. (i.e. Secondary login successfully unlinked!)

App/src/libs/actions/Session/index.js

Lines 763 to 770 in ca8d279

	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.ACCOUNT,
	value: {
	isLoading: false,
	message: Localize.translateLocal('unlinkLoginForm.succesfullyUnlinkedLogin'),
	},
	},

After unlink success, ONYXKEYS.ACCOUNT.MESSAGE will be displayed.

App/src/pages/signin/UnlinkLoginForm.js

Lines 65 to 72 in ca8d279

	{!_.isEmpty(props.account.message) && (
	// DotIndicatorMessage mostly expects onyxData errors so we need to mock an object so that the messages looks similar to prop.account.errors
	<DotIndicatorMessage
	style={[styles.mb5, styles.flex0]}
	type="success"
	messages={{0: props.translate(props.account.message)}}
	/>
	)}

Since props.account.message (i.e. account.message Onyx data) is already translated, and there is no Secondary login successfully unlinked! key in language dictionary, so the error is generated and app crashes.

What changes do you think we should make in order to solve the problem?

We should store message key to Onyx in order to display proper translated message.

    {
        onyxMethod: Onyx.METHOD.MERGE,
        key: ONYXKEYS.ACCOUNT,
        value: {
            isLoading: false,
-           message: Localize.translateLocal('unlinkLoginForm.succesfullyUnlinkedLogin'),
+           message: 'unlinkLoginForm.succesfullyUnlinkedLogin',
        },
    },

What alternative solutions did you explore? (Optional)

None.

[sonialiap]

Didn't get to triaging this bug, I'll take a look at it tomorrow!

[sonialiap]

The app isn't crashing for me but I'm not receiving the magic link after step 5 🐛