[HOLD for payment 2023-07-26] [HOLD for payment 2023-07-24] Workspace - Unable upload picture to Workspace

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with any account
3. Go Setting - Workspace
4. Select any WS and upload a picture

Expected Result:

Able upload picture to Workspace

Actual Result:

Unable upload picture to Workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.41.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.3632.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689315976091129

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Infinite loading when uploading attachment

What is the root cause of that problem?

Problem came from here when our attachment doesn't have URI:

App/src/components/AttachmentPicker/index.js

Lines 39 to 41 in 405fcdf

	if (file) {
	onPicked.current(file);
	}

It will cause AvatarCropModal loading infinite because setIsImageInitialized is never set.

App/src/components/AvatarCropModal/AvatarCropModal.js

Lines 122 to 137 in 405fcdf

	if (!imageUri) {
	return;
	}
	Image.getSize(imageUri, (width, height) => {
	// We need to have image sizes in shared values to properly calculate position/size/animation
	originalImageHeight.value = height;
	originalImageWidth.value = width;
	setIsImageInitialized(true);
	// Because the reanimated library has some internal optimizations,
	// sometimes when the modal is hidden styles of the image and slider might not be updated.
	// To trigger the update we need to slightly change the following values:
	translateSlider.value += 0.01;
	rotation.value += 360;
	});
	}, [imageUri, originalImageHeight, originalImageWidth, rotation, translateSlider]);

What changes do you think we should make in order to solve the problem?

We should add uri to our file in here:

    if (file) {
      file.uri = URL.createObjectURL(file);
      onPicked.current(file);
 }

What alternative solutions did you explore? (Optional)

N/A

[hungvu193]

ah it's dupe of #22882

[Li357]

Repro in production and dupe, closing here

[kbecciv]

Hi! I can not reproduce in production, can you please check again @Li357? Duplicate issue was in Dev and it hit Staging now.
Thank you

Recording.3635.mp4