[HOLD for payment 2023-08-07] [$1000] Web - Still able to access the deleted link on thread

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. On staging dot on web chrome > Go to any chat and type any URL starting with www
2. Now after the URL description appears > Click on reply thread option so that a new thread page opens up
3. On the new thread page, now delete the URL
4. Notice that the URL description is still shown and if you try to click on it, we are still able to access it

Expected Result:

Should not be able to access the deleted link on thread

Actual Result:

Still able to access the deleted link on thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.40-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-07-14_00.22.37.mp4

Recording.3621.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689273337561749

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013ae5682486494f3c
• Upwork Job ID: 1679843925808099328
2023-07-21
• Automatic offers:
• | | 0
• StevenKKC | Contributor | 25748815
• priya-zha | Reporter | 25748819

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013ae5682486494f3c

[melvin-bot]

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Still able to access the deleted link on thread.

What is the root cause of that problem?

When delete comment on thread, Report.deleteReportComment will be called.

But in this function, does not delete linkMeatadata, so the URL description is still shown and still able to access it.

What changes do you think we should make in order to solve the problem?

We should remove linkMetadata in Report.deleteReportComment.

    const optimisticReportActions = {
        [reportActionID]: {
            pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
            previousMessage: reportAction.message,
            message: deletedMessage,
            errors: null,
+           linkMetadata: [],
        },
    };

What alternative solutions did you explore? (Optional)

None.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Deleting a thread message that contains a link does not remove the link preview.

What is the root cause of that problem?

The link preview will show if we have a linkMetadata.

App/src/pages/home/report/ReportActionItem.js

Lines 346 to 350 in 0151134

	{!isHidden && !_.isEmpty(props.action.linkMetadata) && (
	<View style={props.draftMessage ? styles.chatItemReactionsDraftRight : {}}>
	<LinkPreviewer linkMetadata={_.filter(props.action.linkMetadata, (item) => !_.isEmpty(item))} />
	</View>
	)}

When we delete a message, we don't clear the linkMetadata.

What changes do you think we should make in order to solve the problem?

Clear the linkMetadata on deleting a message.

App/src/libs/actions/Report.js

Lines 886 to 893 in 0151134

	const optimisticReportActions = {
	[reportActionID]: {
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
	previousMessage: reportAction.message,
	message: deletedMessage,
	errors: null,
	},
	};

(add linkMetadata: [])

[HezekielT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is able to access deleted link if the link was threaded before being deleted.

What is root cause of that problem?

When we delete a message that has a thread, we delete its text, html and set its isEdited and isDeletedParentAction to true but we do nothing for linkMetadata. So even if the message has been deleted, the linkMetadata contains the preview of the deleted link which means the preview remains intact. This is the root cause.

What Changes do you think we should make in order to solve the problem?

Option 1 – while deleting the link, we can set the linkMetadata to [] in optimisticReportAction of deleteReportComment function.

App/src/libs/actions/Report.js

Lines 886 to 893 in 0151134

	const optimisticReportActions = {
	[reportActionID]: {
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
	previousMessage: reportAction.message,
	message: deletedMessage,
	errors: null,
	},
	};

Option 2 – We can add a condition that checks if the message is deleted and if it is, we do not show the link preview in here.

App/src/pages/home/report/ReportActionItem.js

Lines 346 to 349 in 0151134

	{!isHidden && !_.isEmpty(props.action.linkMetadata) && (
	<View style={props.draftMessage ? styles.chatItemReactionsDraftRight : {}}>
	<LinkPreviewer linkMetadata={_.filter(props.action.linkMetadata, (item) => !_.isEmpty(item))} />
	</View>

What alternative solutions did you explore? (Optional)