[HOLD for payment 2023-08-01] [$1000] Login - The FAB menu is not open when entering the correct magic code on second try

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to staging.new.expensify.com
2. On the login screen enter any email account and click Continue
3. Enter a incorrect magic code
4. Enter the correct magic code

Expected Result:

The FAB menu in the LHN view should be opened

Actual Result:

The FAB menu is not opened when entering the correct magic code on second try

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.39.5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6124291_Recording__348.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a7019e80367e460c
• Upwork Job ID: 1679099061757542400
• Last Price Increase: 2023-07-12

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[getusha]

I am not able to reproduce.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Login - The FAB menu is not open when entering the correct magic code on second try

What is the root cause of that problem?

1. The first time user visits our App, isFirstTimeNewExpensifyUser is undefined

App/src/libs/actions/Welcome.js

Line 17 in d6b2d07

let isFirstTimeNewExpensifyUser;

2. After login to the first account, isFirstTimeNewExpensifyUser is set to boolean (true or false)

App/src/libs/actions/Welcome.js

Lines 42 to 44 in d6b2d07

	if (!isFirstTimeNewExpensifyUser) {
	isFirstTimeNewExpensifyUser = val;
	}

if isFirstTimeNewExpensifyUser is true we open the FAB menu then update isFirstTimeNewExpensifyUser to false to avoid open it later.

3. When user logout we reset isReadyPromise, but not reset isFirstTimeNewExpensifyUser to undefined so it's still false

App/src/libs/actions/Welcome.js

Lines 151 to 155 in d6b2d07

	function resetReadyCheck() {
	isReadyPromise = new Promise((resolve) => {
	resolveIsReadyPromise = resolve;
	});
	}

4. User login with the new account we execute the following function first

App/src/libs/actions/Welcome.js

Line 54 in d6b2d07

checkOnReady();

At this time isFirstTimeNewExpensifyUser is false and isLoadingReportData is false => resolveIsReadyPromise is executed.
We have the logic to early return to avoid showing FAB menu if isFirstTimeNewExpensifyUser is false

App/src/libs/actions/Welcome.js

Lines 109 to 111 in d6b2d07

	if (!isFirstTimeNewExpensifyUser) {
	return;
	}

What changes do you think we should make in order to solve the problem?

resolveIsReadyPromise should be only executed after both isFirstTimeNewExpensifyUser and isLoadingReportData are updated. So I suggest resetting isFirstTimeNewExpensifyUser = undefined and isLoadingReportData = true when we call resetReadyCheck.

Result

Screen.Recording.2023-07-12.at.15.31.27.mp4

[tienifr]

@JmillsExpensify @lanitochka17 I think the steps in requirement is not correct, they should be

1. Navigate to staging.new.expensify.com
2. Login to any account
3. Logout
4. Login to new account

Screen.Recording.2023-07-12.at.15.25.02.mp4

[JmillsExpensify]

I was able to successfully reproduce using these reproduction steps.

Navigate to staging.new.expensify.com
On the login screen enter a any email account and click Continue
Enter an incorrect magic code
Enter the correct magic code

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a7019e80367e460c

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.