[HOLD for payment 2023-10-02] [$1000] Inconsistency in the security page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings > security > Two factor authentication
2. Observe that the next button is not highlighted or clickable unless you copy or download the codes
3. Go to settings > security > Change password
4. Observe that the save button is highlighted and clickable even though you didn't feed the necessary information and fix error option will show up.
5. Go to settings > security > Close account
6. Observe that the Confirm button is highlighted and clickable even though you didn't feed the necessary information and fix error option will show up.

Expected Result:

Button's should be clickable even though the necessary steps are not fulfilled and Fix error options should be shown up instead to keep the app consistency

Actual Result:

Button was not clickable when the necessary steps were not fulfilled and Fix error options was not shown

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.39-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

new.BR.27.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Yokabdk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689037540044139

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0137dd1f2f9d3d3972
• Upwork Job ID: 1679119869039431680
• Last Price Increase: 2023-08-18
2023-07-26
• Automatic offers:
• dukenv0307 | Contributor | 25774623

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[DanutGavrus]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency in the security page

What is the root cause of that problem?

Some buttons should not be disabled from the start, but right now, they are.

What changes do you think we should make in order to solve the problem?

We need to update Two Factor Authentication Page where the button starts disabled, as to be enabled & show the corresponding error if user presses on it without doing anything before. We also need to do this for any other places in which the button starts as disabled, but shouldn't(such as on the Request Money Page).

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency in the security page

What is the root cause of that problem?

We disable the button for first when we open the page

App/src/pages/settings/Security/TwoFactorAuth/CodesPage.js

Line 48 in d6b2d07

const [isNextButtonDisabled, setIsNextButtonDisabled] = useState(true);

What changes do you think we should make in order to solve the problem?

1. We can remove disable logic here

App/src/pages/settings/Security/TwoFactorAuth/CodesPage.js

Line 133 in d6b2d07

isDisabled={isNextButtonDisabled}

2. Create a new state to control error
3. When we press on the next button check if isNextButtonDisable is true and set error state for a translation key that can confirm by design team

onPress={() => {
    if (isNextButtonDisabled) {
        setErrors("Please copy or download the code before going to the next step");
        return;
    }
    Navigation.navigate(ROUTES.SETTINGS_2FA_VERIFY)
}}

App/src/pages/settings/Security/TwoFactorAuth/CodesPage.js

Line 131 in 74ae95c

onPress={() => Navigation.navigate(ROUTES.SETTINGS_2FA_VERIFY)}

4. When we click on the download or copy button, set error to empty

App/src/pages/settings/Security/TwoFactorAuth/CodesPage.js

Line 113 in 74ae95c

onPress={() => {

App/src/pages/settings/Security/TwoFactorAuth/CodesPage.js

Line 103 in 74ae95c

onPress={() => {

5. Add a text before next button to display the error with the style is styles.formError. The style and position to display error need design team to confirm

{errors &&
    <Text style={styles.formError}>{errors}</Text>
}

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.26-07-2023.00.48.01.webm

[CortneyOfstad]

Was able to recreate so going to get eyes on this

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0137dd1f2f9d3d3972

[melvin-bot]

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)