Web - On pressing the + and opening Actions Modal does not close the Tooltip.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open App and navigate to any chat
2. Press + from the composer

Expected Result:

It opens the Actions modal and Tooltip closed

Actual Result:

It opens the Actions modal, but Tooltip is visible.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Safari
• MacOS / Desktop

Version Number: 1.3.37-6
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

tooltip-does-not-close.mov

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688729240640489

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[KrAbhas]

I tested this, all tool tips in safari are behaving like this. This is nor reproducible in chrome (both on macOS and windows).

[multijump]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On pressing the + and opening Actions Modal does not close the Tooltip.

What is the root cause of that problem?

Root Cause is because of the safari's behavior to keep hover while clicking.
Safari always keeps hover state when click it while be on element dislike chrome.

What changes do you think we should make in order to solve the problem?

Actually, we have the handling this case here.

App/src/components/Hoverable/index.js

Line 109 in 882026d

onBlur: (el) => {

This blur function is for Check if the blur event occurred due to clicking outside the element and the wrapperView contains the element that caused the blur and reset isHovered
But we must consider if blur event occurred due to clicking inside the element because of safari's behavior.
So we can fix to just remove one condition like this in here.

if (!this.wrapperView.contains(el.relatedTarget)) {
      this.setIsHovered(false);
}

What alternative solutions did you explore? (Optional)

N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[muttmuure]

Not had time

[melvin-bot]

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

Working on a fire