[HOLD for payment 2023-08-01] [$1000] App allows to add link in code block and does not display the same on copy and send

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Send link in following format : Test
4. Observe that it displays link inside code block (till now, we have intentionally made sure to not display link in code block)
5. Hover and click on copy to clipboard
6. Paste in compose box and send
7. Observe that now, it does not display link in code block

Expected Result:

App should not display link inside code block and maintain same display format on copy to clipboard and send again as message

Actual Result:

App displays link inside code block if sent in specific format and on copy to clipboard and sending as normal message, it does not maintain the format

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.38-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

link.in.code.block.and.not.maintaining.format.mp4

Recording.1224.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688796230285319

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f921043b5d238f9f
• Upwork Job ID: 1678721695254556672
• Last Price Increase: 2023-07-11

[eh2077]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App allows to add link in code block and does not display the same on copy and send.

What is the root cause of that problem?

The following markdown input

[```code```](google.com)

is translated into html

<a href="https://google.com" target="_blank" rel="noreferrer noopener"><pre>code</pre></a>

from frontend by method ExpensiMark.replace applying code fence rule and link rule.

The backend corrects the above html into following html

<a href="https://google.com" target="_blank" rel="noreferrer noopener"></a><pre><a href="https://google.com" target="_blank" rel="noreferrer noopener">code</a></pre><a href="https://google.com" target="_blank" rel="noreferrer noopener"></a>

which is translated into following markdown when clicking to edit the comment

```
[code](https://google.com)
```

Note the starting and ending anchor tag, <a href="https://google.com" target="_blank" rel="noreferrer noopener"></a>, are same and translated into empty string.

So, the root cause of this issue is that the link rule doesn't skip to translate markdown link syntax if its alias text inside [] contains code fence tag <pre>.

What changes do you think we should make in order to solve the problem?

To fix this issue, we should avoid translating link markdown syntax if its alias text part contains <pre> tag.

To achieve it, we can change following condition

https://github.com/Expensify/expensify-common/blob/d636fef3f22b4e5fcf61333ddc89a5d2e08cacc9/lib/ExpensiMark.js#L454

of method modifyTextForUrlLinks by checking if the alias text part, match[1], includes <pre> tags

if (abort || match[1].includes('<pre>')) {

to skip replacing link syntax to html.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f921043b5d238f9f

[zanyrenney]

Reviewed, adding external.

[melvin-bot]

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.