[HOLD for payment 2023-08-14] [HOLD for payment 2023-08-07] [$1000] Invite Member - No way to remove RBR from avatar after inviting an invalid number into a workspace

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a workspace and go to invite members page
2. Paste an invalid number like "+916541237890" inside the search field and select it
3. Click next > invite
4. Go back to LHN and observe there is a RBR on it
5. Click on avatar > follow the RBR and click on workspace > members

Expected Result:

There should be a way to remove the RBR from avatar and settings

Actual Result:

There is no way to remove RBR from settings after inviting an invalid member into a workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.37-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-07-06.10.59.08.mp4

Recording.3460.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688630661683609

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012f84973149e5c0ce
• Upwork Job ID: 1678916595916169216
• Last Price Increase: 2023-07-18

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invite Member - No way to remove RBR from avatar after inviting an invalid number into a workspace

What is the root cause of that problem?

even when api returns an error still that member is included in policy members and obviously it shows an error for this

Looks like we are intentionally adding members with errors....and removing the error in OfflineWithFeedBack but OfflineWithFeedback's on close method never gets triggered hence these errors are not getting dismisses

What changes do you think we should make in order to solve the problem?

Solution 1
we should not add members in policy members object if api returns an error while adding them,
Solution 2
We can set there errors to null

I don't get the point of keeping that invalid entry in policy members list. We can again add it multiple times. This is the same invalid entry that I have added multiple times.

What alternative solutions did you explore? (Optional)

[Christinadobrzyn]

might be related to - #20961 (comment) asking

[Nathan-Mulugeta]

Just as an info, this issue was introduced on this week's latest release, I think #20961 was reported 20 days ago. This issue was not there then.

[Christinadobrzyn]

Ah okay, thank you @Nathan-Mulugeta! It does sound like it might be separate then but I'll wait to confirm with @PauloGasparSv. Thanks!

[Christinadobrzyn]

watching for an update #20961 (comment)

[Christinadobrzyn]

Not related to #20961 (comment) - moving forward with treating this separately!

I can reproduce but I'm not sure how we want to remove the RBR - any suggestions @Nathan-Mulugeta