[HOLD for payment 2023-08-24] [$1000] Web - Magic codes are sent twice when submitting an email/phone number by pressing Enter key on the keyboard several time continuously

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Enter an Email or Phone number in the login form
2. Press the Enter key on the keyboard several times continuously
3. Check the magic code sent to Email or sms

Expected Result:

Only 1 magic code is sent

Actual Result:

2 magic codes are sent in 2 different emails/sms

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.34-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Magic-Code-Sent-Twice.1.mov

Gravar.2737.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688233631561079

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01315c4b8db9988ccb
• Upwork Job ID: 1675655802425208832
• Last Price Increase: 2023-07-24
• Automatic offers:
• situchan | Reviewer | 26032190
• mkhutornyi | Contributor | 26032192
• tranvantoan-qn | Reporter | 26032195

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[sophiepintoraetz]

I'm able to repro (pressed enter a few times, note the timestamps of the magic code delivery). This might be internal.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01315c4b8db9988ccb

[melvin-bot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[alexxxwork]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Magic code sent twice when pressing enter multiply times

What is the root cause of that problem?

We don't have debounce on 'Sign in' button so the "Sign in" button could be called again after it has been already pressed and before interface re-render.

What changes do you think we should make in order to solve the problem?

We could just use debounce here

App/src/pages/signin/LoginForm.js

Line 165 in c0ece67

Session.beginSignIn(parsedPhoneNumber.possible ? parsedPhoneNumber.number.e164 : login);

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Magic code send multiple times

What is the root cause of that problem?

after submitting the first time magic code isLoading set to true. but in the validateAndSubmitForm() method not block the second time submit.

What changes do you think we should make in order to solve the problem?

we should add a condition for blocking the request if the request is already submitted or pending state.
like this in validateAndSubmitForm method

    if(this.props.account.isLoading) {
        return;
    }

What alternative solutions did you explore? (Optional)

N/A