[HOLD for payment 2023-08-01] Back button after clicking on menu gets back to list of workspace on admins channel( works well if not clicked on menu)

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to web chrome on staging dot
2. Go to any admins channel and click on header
3. Click on workspace name below admins channel and notice the workspace opens up
4. Now click on back button and see it naviagtes back to admin channel which is working well
5. But now again click on workspace and now click on any menu of the workspace and click on back button so that we can get back to admins channel
6. But notice that on clicking on back button from the workspace page, it navigates to the workspace lists (Whereas in the previous case, it navigated back to the admins channel)

Expected Result:

The back button after clicking on menu should get back to admins channel

Actual Result:

Back button after clicking on menu gets back to list of workspace on admins channel( works well if not clicked on menu)

Workaround:

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-06-07_18.01.26.mp4

Recording.2290.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686140160128449

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking back button after clicking on menu gets back to list of workspace on admins channel.

What is the root cause of that problem?

If the user clicks on the workspace name on the report detail page, the navigation will create a new item in the RightModalNavigator because Report_Details_Root and Workspace_Initial are different screens in linkingConfig.
Therefore, there are two items in the RightModalNavigator.

When user click menu, the menu item and workspace initial page are on the same screen in linkingConfig, new item will be added to Workspace_Initial.

When the user clicks the back button, navigation will iterate Workspace_Settings screen routes and return 0.

App/src/libs/Navigation/Navigation.js

Lines 45 to 61 in b0add94

	const getActiveRouteIndex = function (route, index) {
	if (route.routes) {
	const childActiveRoute = route.routes[route.index || 0];
	return getActiveRouteIndex(childActiveRoute, route.index || 0);
	}
	if (route.state && route.state.routes) {
	const childActiveRoute = route.state.routes[route.state.index || 0];
	return getActiveRouteIndex(childActiveRoute, route.state.index || 0);
	}
	if (route.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR) {
	return 0;
	}
	return index;
	};

And since fallbackRoute is set, fallbackRoute will be navigated accordingly.

App/src/libs/Navigation/Navigation.js

Lines 99 to 102 in b0add94

	if (shouldEnforceFallback || (!getActiveRouteIndex(navigationRef.current.getState()) && fallbackRoute)) {
	navigate(fallbackRoute, 'UP');
	return;
	}

fallbackRoute is set to ROUTES.SETTINGS_WORKSPACES, so we'll be returned to the list of workspaces.

App/src/pages/workspace/WorkspaceInitialPage.js

Line 197 in b0add94

onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WORKSPACES)}

What changes do you think we should make in order to solve the problem?

We can modify this line as below.

-   if (shouldEnforceFallback || (!getActiveRouteIndex(navigationRef.current.getState()) && fallbackRoute)) {
+   if (shouldEnforceFallback || (getActiveRouteIndex(navigationRef.current.getState()) == null && fallbackRoute)) {

What alternative solutions did you explore? (Optional)

We can remove fallbackRoute in WorkspaceInitialPage.js.

-   onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WORKSPACES)}
+   onBackButtonPress={() => Navigation.goBack()}

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[JmillsExpensify]

Slammed with bug reports. I'll close the loop on these today.

[melvin-bot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

@mountiny more navigation bugs. I wanted to confirm that we should actually go UP vs BACK in this case?