[HOLD] [$1000] iOS: Paypal.me payment method disappears when deleting a PayPal user name offline

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings then choose Payments
2. Click on Add payment method button.
3. Choose paypal.me
4. Now turn off your internet connection and be offline
5. Insert user name and click on Add Paypal Account
6. Now click the account you added and Delete the account.
7. Now turn on your internet connection and be online.
8. Now click the Add Payment Method button. Notice that the paypal.me choice is not there.

Expected Result:

Paypal.me payment method should be there

Actual Result:

Paypal.me payment method is not there

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1687804398.MP4

PayPall.0107.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687805526273609

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01424c2ea7e73e9df8
• Upwork Job ID: 1675717205927723008
• Last Price Increase: 2023-07-10

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[sophiepintoraetz]

Reproduced!
https://github.com/Expensify/App/assets/42940078/48928ec1-d6e8-4812-a3d2-6bb3bf9201df

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01424c2ea7e73e9df8

[melvin-bot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[asadath1395]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Paypal.me payment method disappears when deleting a PayPal user name offline

What is the root cause of that problem?

Its happening because of mixing onyx merge and set methods. We can see the error in the console after following the reproduction method and going online. The doc also mentions not to mix both the methods. As a result of mixing both the methods, seems like the set method which is supposed to remove the key gets ignored. Also when the user is online and he tries to delete the Paypal.me method, we are setting the optimisticData different inorder to show the user the payment is being deleted, the following is the API response we get

  {
      "jsonCode": 200,
      "requestID": "7e0cf514bf8c2fe3-CNN",
      "onyxData": [
          {
              "onyxMethod": "set",
              "key": "paypal",
              "value": null
          }
      ]
  }

but in the code we have the following optimistic data

App/src/libs/actions/User.js

Lines 535 to 541 in c0ece67

	const optimisticData = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.PAYPAL,
	value: {pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE},
	},
	];

We can see that the onyxMethod and value is not matching with the API response. Because of wrong optimistic data, the list is getting filtered here

App/src/pages/settings/Payments/PaymentMethodList.js

Lines 149 to 154 in c0ece67

	if (!network.isOffline) {
	combinedPaymentMethods = _.filter(
	combinedPaymentMethods,
	(paymentMethod) => paymentMethod.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || !_.isEmpty(paymentMethod.errors),
	);
	}

because the pendingAction is set to CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE. Even after the user coming online and the API being successful, the wrong data still lies in the Onyx store and the set method is ignored resulting in stale data in onyx store and the above filter removes it always. Also on a side-note, the value set here

App/src/libs/actions/User.js

Lines 544 to 550 in d8e6cdf

	const successData = [
	{
	onyxMethod: Onyx.METHOD.SET,
	key: ONYXKEYS.PAYPAL,
	value: {},
	},
	];

is not correct, as the API gives null in the response we are setting it as {}

What changes do you think we should make in order to solve the problem?

1. We can update the optimistic data to match the API response the problem with this approach is the feedback of showing user the payment method is getting deleted will be lost
2. Fix the API response to make both the add and delete consistent method

What alternative solutions did you explore? (Optional)

NA

[manjesh-yadav]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Paypal.me payment method disappears when deleting a PayPal user name offline

What is the root cause of that problem?

• We add Paypal.me in offline mode and then Delete the same Paypal.me in offline mode.
• That makes two API calls persisted to disk addPaypalMeAddress and deletePaypalMeAddress
• When we go online that two API call simultaneously

Unfortunately, we use Onyx.merge for addPaypalMeAddress and Onyx.set for deletePaypalMeAddress with same key Onyx key paypal but it is recommended use set or merge at once not both

Actually, we use Onyx.set for deletePaypalMeAddress for solving issue in PR

App/src/libs/actions/User.js

Lines 542 to 550 in c0ece67

	// Success data required for Android, more info here https://github.com/Expensify/App/pull/17903#discussion_r1175763081
	const successData = [
	{
	onyxMethod: Onyx.METHOD.SET,
	key: ONYXKEYS.PAYPAL,
	value: {},
	},
	];

What changes do you think we should make in order to solve the problem?

Solution 1

We can also use Onyx.METHOD.SET (Onyx.set) for addPaypalMeAddress to avoid conflict.

Soluciton 2

I check we hide add payment method button in offline mode for the Debit card and Bank accounts we can also hide it for Papal.me to avoid conflict.

What alternative solutions did you explore? (Optional)

Hide payment method for Papal.me in offline mode