[HOLD for payment 2023-08-08] [$1000] [HOLD] Context menu from LHN is visible even if report page is opened on resize

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Right click an option in LHN.
2. Resize the window to small while the menu is still open

Expected Result:

The menu should either stay open and LHN should be visible or the menu should close and report screen should be visible.

Actual Result:

The menu as well as report screen is visible while the action LHN option is hidden.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.34-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.2276.mp4

Screen.Recording.2023-06-26.at.10.27.18.PM.1.mov

Expensify/Expensify Issue URL:
Issue reported by: @esh-g
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687798787632109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cdbc23c40a03345b
• Upwork Job ID: 1681398364212076544
2023-07-18
• Automatic offers:
• | | 0
• | | 0
• esh-g | Reporter | 25767058

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[spcheema]

Proposed solution

Please re-state the problem that we are trying to solve in this issue.

Context menu from LHN is visible even if report page is opened on resize. S

What is the root cause of that problem?

We are not hiding the ReportActionMenu whenever screen size changes to small and a report is selected.

What changes do you think we should make in order to solve the problem?

We can utilise the isSmallScreenWidth props on SidebarLinks render to check screen size and hide the ReportActionMenu is it's set in the contextMenuRef

        if (this.props.isSmallScreenWidth)
        {
           // ReportActionContextMenu
            hideContextMenu(false)
        }

What alternative solutions did you explore? (Optional)

N/A

[esh-g]

I think we should put this on hold for this issue: #20370 (comment)

[maddylewis]

holding for - #20370 (comment)

[maddylewis]

still holding