[HOLD for payment 2023-07-20] [$1000] Compose box is stuck with non removable space if we add space, click on upper arrow to edit and save edited message

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Send any message
4. Enter space in compose box
5. Click on upper arrow until last message enter edit made
6. Save the edit message with or without any changes
7. Observe that app again focuses to compose box, there is already a space entered in compose box, try to delete it and observe that it is not getting deleted (2 ways to say there is space in compose box, pencil icon is displayed in LHN and 'Write something' placeholder is not displayed)

Expected Result:

App should allow to remove space in compose box on refocus after editing any message

Actual Result:

App should allow to remove space in compose box if we add space, click upper arrow to edit any message and save that message with or without any changes

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.34-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

space.not.removable.compose.box.mp4

Recording.963.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687785005400489

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013f762cbe49f78f72
• Upwork Job ID: 1675898254628552704
• Last Price Increase: 2023-07-03

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Compose box is stuck with non removable space if we add space, click on upper arrow to edit and save edited message

What is the root cause of that problem?

When press up arrow, we handled it here:

        if (
            e.key === CONST.KEYBOARD_SHORTCUTS.ARROW_UP.shortcutKey &&
            this.textInput.selectionStart === 0 &&
            this.state.isCommentEmpty &&
            !ReportUtils.chatIncludesChronos(this.props.report)
        ) {
            e.preventDefault();

            const parentReportActionID = lodashGet(this.props.report, 'parentReportActionID', '');
            const parentReportAction = lodashGet(this.props.parentReportActions, [parentReportActionID], {});
            const lastReportAction = _.find([...this.props.reportActions, parentReportAction], (action) => ReportUtils.canEditReportAction(action));

            if (lastReportAction !== -1 && lastReportAction) {
                Report.saveReportActionDraft(this.props.reportID, lastReportAction.reportActionID, _.last(lastReportAction.message).html);
            }
        }

So if comment is empty and selectionStart equals 0, we will move to edit last sent message. But we also remove all the spaces to calculate the isCommentEmpty. So this issue, cursor at the start and after editing message, you can't delete the space because you're at the start of the line.

What changes do you think we should make in order to solve the problem?

Solution 1:

Move cursor at the end by updating the selection after pressing ArrowUp in here

Solution 2:

We shouldn't allow user to edit previous component if it's not really empty (Because space is valid draft value). So we will need to update the condition of trigger ArrowUp to:

        if (
            e.key === CONST.KEYBOARD_SHORTCUTS.ARROW_UP.shortcutKey &&
          // only allow to update when it's has length === 0
            this.textInput.selectionStart === 0 &&
            this.state.value.length === 0 &&
            !ReportUtils.chatIncludesChronos(this.props.report)
        ) {
            e.preventDefault();

            const parentReportActionID = lodashGet(this.props.report, 'parentReportActionID', '');
            const parentReportAction = lodashGet(this.props.parentReportActions, [parentReportActionID], {});
            const lastReportAction = _.find([...this.props.reportActions, parentReportAction], (action) => ReportUtils.canEditReportAction(action));

            if (lastReportAction !== -1 && lastReportAction) {
                Report.saveReportActionDraft(this.props.reportID, lastReportAction.reportActionID, _.last(lastReportAction.message).html);
            }
        }

or we can introduce a new variable hasDraft similar to other places as an alternative for this.state.value.length === 0.

What alternative solutions did you explore? (Optional)

N/A

[kevinksullivan]

can't reproduce

https://expensify.slack.com/archives/C049HHMV9SM/p1688164226012059?thread_ts=1687785005.400489&cid=C049HHMV9SM

[hungvu193]

@kevinksullivan I'm still able to reproduce on latest main

[kevinksullivan]

Still getting clarification in thread.

[kevinksullivan]

Was able to reproduce with some guidance in slack.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013f762cbe49f78f72