[HOLD for payment 2023-07-17] [$1000] Web - Inconsistency bug: cursor turns to arrow on task report item

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1, Click on 'FAB' icon
2. Click on 'Assign task'
3. Enter title & click on 'Next' button
4. Click on 'Assignee'
5. Search for a user & select the user
6. Click on 'Confirm task' button
7. Open the chat with the user you have assigned a task to
8. Hover over the newly created task report item

Expected Result:

Cursor should turn to hand since the task report item is clickable

Actual Result:

Cursor turns to an arrow

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.34-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-06-28.18-14-16.1.mp4

Recording.960.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687965183006359

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0139471d08018015c7
• Upwork Job ID: 1674504778229022720
• Last Price Increase: 2023-06-29

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cursor turns to arror on task report item.

What is the root cause of that problem?

Task report item is displayed in TaskPreview, and there is no style set to an hand.

App/src/components/ReportActionItem/TaskPreview.js

Lines 71 to 86 in c83b2d1

	<View style={[styles.flex1, styles.flexRow, styles.alignItemsStart]}>
	<Checkbox
	style={[styles.mr2]}
	containerStyle={[styles.taskCheckbox]}
	isChecked={isTaskCompleted}
	disabled={TaskUtils.isTaskCanceled(props.taskReport)}
	onPress={() => {
	if (isTaskCompleted) {
	TaskUtils.reopenTask(props.taskReportID, taskTitle);
	} else {
	TaskUtils.completeTask(props.taskReportID, taskTitle);
	}
	}}
	/>
	<RenderHTML html={htmlForTaskPreview} />
	</View>

What changes do you think we should make in order to solve the problem?

We can add hand style to this line in TaskPreview.js, just like this line in MoneyRequestAction.js.

-    <View style={[styles.flex1, styles.flexRow, styles.alignItemsStart]}>
+    <View style={[styles.flex1, styles.flexRow, styles.alignItemsStart, styles.cursorPointer]}>

What alternative solutions did you explore? (Optional)

None.

[slafortune]

report looks good 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0139471d08018015c7

[melvin-bot]

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cursor turns to arrow on task report action item

What is the root cause of that problem?

App/src/components/ReportActionItem/TaskPreview.js

Line 67 in 6cf8417

style={[styles.flexRow, styles.justifyContentBetween, styles.chatItemMessage]}

styles.chatItemMessage has cursor style and it overrides PressableWithoutFeedback's cursor style

What changes do you think we should make in order to solve the problem?

omit cursor in chatItemMessage like this:
style={[styles.flexRow, styles.justifyContentBetween, _.omit(styles.chatItemMessage, 'cursor')]}