[HOLD for payment 2023-07-21] [$1000] Inconsistency - Link previews have different border color than quotes

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app.
2. Send a quote message in any chat. ex - > hello.
3. Send a link. ex - google.com and wait for the link preview to appear.
4. Notice that the left border has a different color in both cases.

Expected Result:

Border color should be consistent for both link previews and quote.

Actual Result:

Border color is different for both link preview and quote.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.33-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-28.at.9.01.07.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @Nikhil-Vats Bortman
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687966486390789

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01034485de0b01882f
• Upwork Job ID: 1676724101797347328
• Last Price Increase: 2023-07-05

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

by @Nikhil-Vats

Please re-state the problem that we are trying to solve in this issue.

Left border color for link previews is inconsistent with blockquote's left border color.

What is the root cause of that problem?

We are using a different color for link previews left border.

App/src/styles/styles.js

Lines 3364 to 3369 in a23d161

	linkPreviewWrapper: {
	marginTop: 16,
	borderLeftWidth: 4,
	borderLeftColor: getTransparentColor(themeColors.inverse, 33),
	paddingLeft: 12,
	},

App/src/styles/styles.js

Lines 2680 to 2681 in a23d161

	blockquote: {
	borderLeftColor: themeColors.border,

What changes do you think we should make in order to solve the problem?

We should just change the border color used for link previews to be the same as other one - themeColors.border.
Optionally, we can also remove the function getTransparentColor which was added for link previews border color and is only used there.

What alternative solutions did you explore? (Optional)

NA

[Nikhil-Vats]

My proposal above.

[mallenexpensify]

@Nikhil-Vats you mean these two are different colors, right?

[Nikhil-Vats]

Yes @mallenexpensify .

[Nikhil-Vats]

@mallenexpensify This was reported by Shawn here and @wojtus7 provided confirmation here.

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?