[HOLD for payment 2023-07-12][$1000] All task related pages have extra padding between header and content

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to ND
2. Click on FAB Icon
3. Click on Assign task
4. Notice on assign page Header and content has huge extra spacing then other pages (this can be quick compare by navigating to profile page (from drawer) notice here padding between header and contact does not have extra padding
5. This extra padding gap of (20px) can be found on all task related pages like Assign task, confirm task, task title ,task description pages

Expected Result:

There should be no extra padding between header and content just like all other pages (consistency across the similar pages on app)

Actual Result:

There is extra padding between header and content on all task related pages

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.33-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687764851615229

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a5dc2de852edd528
• Upwork Job ID: 1674640685641990144
• Last Price Increase: 2023-06-30

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal

Please re-state the problem that we are trying to solve in this issue.

All task related pages have extra padding between header and content

What is the root cause of that problem?

The root cause is we might have added extra styles.mt5 to parent view of the all below screens during initial phase which was not required as per code consistency

What changes do you think we should make in order to solve the problem?

Solution - 1

We need to remove extra styles.mt5 padding on below pages as we don’t required since header already has enough padding

App/src/pages/tasks/NewTaskDetailsPage.js

Line 87 in c261901

style={[styles.mh5, styles.mt5, styles.flexGrow1]}

App/src/pages/tasks/NewTaskPage.js

Line 153 in c261901

<View style={[styles.mt5, styles.containerWithSpaceBetween]}>

App/src/pages/tasks/NewTaskTitlePage.js

Line 88 in c261901

style={[styles.mh5, styles.mt5, styles.flexGrow1]}

App/src/pages/tasks/NewTaskDescriptionPage.js

Line 82 in c261901

style={[styles.mh5, styles.mt5, styles.flexGrow1]}

Solution -2

Apply required padding-top on above files (but mostly solution - 1 is recommend as it makes all this pages consistent with other pages

[kadiealexander]

@thienlnam @shawnborton Just wanted to check that this padding isn't intentional before we fix it, any advice please?

[shawnborton]

I agree that we should remove that extra padding to be consistent with other pages. Thoughts @thienlnam ?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a5dc2de852edd528

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)