[HOLD for payment 2023-07-21] [$1000] Share somewhere doesn't update in room while selecting user/group

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a room
2. select '+" icon and click assign task ( It must be done within room)
3. Add title and description
4. Go to share somewhere and click on any other rooms/ contact list.
   ( Notice that while clicking other groups too, only default room on which the task is created is shown.)

Expected Result:

Either, multiple groups should be selectable and should be updated as like assign task done from LHN,
OR, sharing somewhere should be made unchooseable, and only default room should be shown

Actual Result:

Share somewhere doesn't update in room while selecting user/group

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.32-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.5175.mp4

Screen.Recording.2023-06-21.at.6.19.37.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687351420861259

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cdc2396412f39341
• Upwork Job ID: 1674191448143474688
• Last Price Increase: 2023-07-05

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Share somewhere doesn't update in room while selecting user/group.

What is the root cause of that problem?

When select user/group in share somewhere page, task.shareDestination will be set.

App/src/pages/tasks/TaskShareDestinationSelectorModal.js

Lines 117 to 122 in 5c6b751

	if (option.reportID) {
	// Clear out the state value, set the assignee and navigate back to the NewTaskPage
	setSearchValue('');
	TaskUtils.setShareDestinationValue(option.reportID);
	Navigation.goBack();
	}

After return to create task page, because task.parentReportID is set, task.shareDestination will be set to original value.

App/src/pages/tasks/NewTaskPage.js

Lines 98 to 100 in 5c6b751

	if (props.task.parentReportID) {
	TaskUtils.setShareDestinationValue(props.task.parentReportID);
	}

Therefor share somewhere doesn't update.

What changes do you think we should make in order to solve the problem?

When select user/group, we should clear task.parentReportID in TaskShareDestinationSelectorModal.

        if (option.reportID) {
            // Clear out the state value, set the assignee and navigate back to the NewTaskPage
            setSearchValue('');
            TaskUtils.setShareDestinationValue(option.reportID);
+           TaskUtils.setParentReportID(null);
            Navigation.goBack();
        }

setParentReportID function is not exported in Task.js, so we should export setParentReportID function.

What alternative solutions did you explore? (Optional)

None.

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[Nikhil-Vats]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Share somewhere doesn't update when creating a task from a chat (report).

What is the root cause of that problem?

In TaskShareDestinationSelectorModal, we don't update parentReportID when updating share destination -

App/src/pages/tasks/TaskShareDestinationSelectorModal.js

Lines 117 to 122 in 67561d8

	if (option.reportID) {
	// Clear out the state value, set the assignee and navigate back to the NewTaskPage
	setSearchValue('');
	TaskUtils.setShareDestinationValue(option.reportID);
	Navigation.goBack();
	}

In NewTaskPage we override the share somewhere in the lines below so it cannot be changed to any user/group/room other than the parent report if we create a task from a report.

App/src/pages/tasks/NewTaskPage.js

Lines 95 to 100 in 67561d8

	// We only set the parentReportID if we are creating a task from a report
	// this allows us to go ahead and set that report as the share destination
	// and disable the share destination selector
	if (props.task.parentReportID) {
	TaskUtils.setShareDestinationValue(props.task.parentReportID);
	}

What changes do you think we should make in order to solve the problem?

We should also change the parentReportID when changing the share somewhere destination in TaskShareDestinationSelectorModal -

To do that, we can call the setParentReportID in setShareDestinationValue function in TaskUtils -

/**
 * Sets the shareDestination value for the task
 * @param {string} shareDestination
 */
function setShareDestinationValue(shareDestination) {
    // This is only needed for creation of a new task and so it should only be stored locally
    Onyx.merge(ONYXKEYS.TASK, {shareDestination});
    setParentReportID(shareDestination); // call this function also when changing the share destination
    // this will also update the parentReportID so that share destination will not be overridden in `NewTaskPage`
}

setParentReportID is defined after setShareDestinationValue so we will need to reorder and define setParentReportID before setShareDestinationValue to use it in setShareDestinationValue.

Alternatively, we can export setParentReportID and use it in TaskShareDestinationSelectorModal -

if (option.reportID) {
    // Clear out the state value, set the assignee and navigate back to the NewTaskPage
    setSearchValue('');
    TaskUtils.setShareDestinationValue(option.reportID); // alternatively, call `setParentReportID` in this function and remove next line
    TaskUtils.setParentReportID(option.reportID);
    Navigation.goBack();
}

What alternative solutions did you explore? (Optional)

Since, the user has clicked on assign task from a chat and not FAB in LHN, we can make the share somewhere field un-interactive when creating a task from a report.

This is consistent with send/request money in a report. We do not let user change the payee in request/send money page if they opened the page from a report.

To disable share somewhere when we click on assign task from a report, we can use the interactive prop to make it non interactive if parentReportID is set -

<MenuItem
    label={shareDestination.displayName ? props.translate('newTaskPage.shareSomewhere') : ''}
    title={shareDestination.displayName || ''}
    description={shareDestination.displayName ? shareDestination.subtitle : props.translate('newTaskPage.shareSomewhere')}
    icon={shareDestination.icons}
    onPress={() => Navigation.navigate(ROUTES.NEW_TASK_SHARE_DESTINATION)}
    interactive={!Boolean(props.task.parentReportID)} // make the field non interactive if parentReportID is set
    shouldShowRightIcon={!Boolean(props.task.parentReportID)} // don't show right icon if parentReportID is set
/>

Screen.Recording.2023-07-07.at.11.12.53.PM.mov

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We can't change the Share Somewhere field when creating a task within a report.

What is the root cause of that problem?

When we are creating a task within a report, it will autofill the Share Somewhere field (currently it's not working because of this issue) with the report we initiated the new task on.

App/src/pages/tasks/NewTaskPage.js

Lines 95 to 100 in e5f00f8

	// We only set the parentReportID if we are creating a task from a report
	// this allows us to go ahead and set that report as the share destination
	// and disable the share destination selector
	if (props.task.parentReportID) {
	TaskUtils.setShareDestinationValue(props.task.parentReportID);
	}

parentReportID is the ID of the report on which we initiated the new task.

The problem is, the code above is put inside a useEffect with a dependency array of [props] which means it will rerun every time ANY props are changed. This will produce unexpected side effects as we have in this issue.

In this case, when we select a new Share Somewhere, it will also trigger the code above which will just override the new selected Share Somewhere with the parentReportID.

What changes do you think we should make in order to solve the problem?

To prevent any unexpected side effects, we should extract it out into a separate useEffect with a dependency array that is only needed, in this case, props.task.parentReportID.

useEffect(() => {
    if (props.task.parentReportID) {
        TaskUtils.setShareDestinationValue(props.task.parentReportID);
    }
}, [props.task.parentReportID]);

---

We can do the same thing to all (4) conditions inside the useEffect.

App/src/pages/tasks/NewTaskPage.js

Lines 75 to 109 in e5f00f8

	useEffect(() => {
	setErrorMessage('');
	// If we have an assignee, we want to set the assignee data
	// If there's an issue with the assignee chosen, we want to notify the user
	if (props.task.assignee) {
	const assigneeDetails = lodashGet(OptionsListUtils.getPersonalDetailsForAccountIDs([props.task.assigneeAccountID], props.personalDetails), props.task.assigneeAccountID);
	if (!assigneeDetails) {
	return setErrorMessage(props.translate('newTaskPage.assigneeError'));
	}
	const displayDetails = TaskUtils.getAssignee(assigneeDetails);
	setAssignee(displayDetails);
	}
	// If we don't have an assignee and we are creating a task from a report
	// this allows us to auto assign a participant of the report.
	if (!props.task.assignee && props.task.parentReportID) {
	TaskUtils.setAssigneeValueWithParentReportID(props.task.parentReportID);
	}
	// We only set the parentReportID if we are creating a task from a report
	// this allows us to go ahead and set that report as the share destination
	// and disable the share destination selector
	if (props.task.parentReportID) {
	TaskUtils.setShareDestinationValue(props.task.parentReportID);
	}
	// If we have a share destination, we want to set the parent report and
	// the share destination data
	if (props.task.shareDestination) {
	setParentReport(lodashGet(props.reports, `report_${props.task.shareDestination}`, {}));
	const displayDetails = TaskUtils.getShareDestination(props.task.shareDestination, props.reports, props.personalDetails);
	setShareDestination(displayDetails);
	}
	}, [props]);

What alternative solutions did you explore? (Optional)

We can use interactive props (apply to the MenuItem) to "disable" the Share somewhere field.

interactive={!Boolean(props.task.parentReportID)}
shouldShowRightIcon={!Boolean(props.task.parentReportID)}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cdc2396412f39341

[melvin-bot]

Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new.