[HOLD for payment 2023-07-10] [$1000] Desktop - Two keyboard shortcuts to open keyboard shortcuts modal

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Press CMD+J
2. Press ESC
3. Press CMD+I
4. Press ESC

Expected Result:

Only one of these keyboard shortcuts should open the keyboard shortcuts information modal.

Actual Result:

Both keyboard shortcuts open the keyboard shortcuts information modal, which is just a bit weird / makes our app more likely to conflict with other shortcuts.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.30-5
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

No video

Expensify/Expensify Issue URL:
Issue reported by: Rory Abraham
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687451916488959

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0105de33e8954123db
• Upwork Job ID: 1673409124664610816
• Last Price Increase: 2023-06-26

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[puneetlath]

I'm able to reproduce this on Desktop. I'm guessing only CMD+J should open the dialog, since that's what the dialog itself says.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0105de33e8954123db

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.