[WAITING ON ASHIM] [$1000] Web - Task name is not searchable

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to '+" button,
2. Go to assign task -> add task name -> next
3. Add assignee and share to whom
4. Now a new page with a task details should appear.
5. Go to LHN and search for the particular task.
   Notice that it shows " Results not found".

Expected Result:

The task name should be searchable. It will be easier to search, manage and complete tasks.

Actual Result:

The task name is not searchable causing difficult to locate tasks.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.32-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Untitled_video.2.mov

Recording.5155.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687420359552779

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b3d8ba26f1f06973
• Upwork Job ID: 1676016162463776768
• Last Price Increase: 2023-07-10

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[shawnborton]

Hmm yeah, I would expect anything that shows up in the LHN to be available in Search.

@mountiny @danieldoglas thoughts on this one?

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Task name is not searchable

What is the root cause of that problem?

Our search function has the value includeTasks: false by default, so we couldn't see the task in our search result.

App/src/libs/OptionsListUtils.js

Line 596 in f867c17

includeTasks = false,

What changes do you think we should make in order to solve the problem?

In order to see task in our SearchPage, we can add includeTasks: true in our getSearchOptions function.

Also we need to update our createOptions function here to make our search task result has alternateText:

        if (result.isChatRoom || result.isPolicyExpenseChat) {
            result.alternateText = showChatPreviewLine && !forcePolicyNamePreview && lastMessageText ? lastMessageText : subtitle;
        } else if (result.isMoneyRequestReport) {
            result.alternateText = lastMessageTextFromReport.length > 0 ? lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet');
        } else if (result.isTaskReport) {
// update the alternateText for task report
            result.alternateText = showChatPreviewLine && lastMessageText ? lastMessageTextFromReport :  Localize.translate(preferredLocale, 'report.noActivityYet');
        } else {
            result.alternateText = showChatPreviewLine && lastMessageText ? lastMessageText : LocalePhoneNumber.formatPhoneNumber(personalDetail.login);
        }

And finally update the visibility of the title inside our OptionRow here:

 shouldUseFullTitle={
    this.props.option.isChatRoom || this.props.option.isPolicyExpenseChat || this.props.option.isMoneyRequestReport || 
    this.props.option.isThread || this.props.option.isTaskReport
}

What alternative solutions did you explore? (Optional)

N/A

Result:

Screen.Recording.2023-07-04.at.17.46.20.mov