[HOLD for payment 2023-08-21] [$2000] Hitting enter key on keyboard does not select a pronoun

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open ND on android
2. Go to settings > Profile > Pronouns
3. Search a pronoun
4. Hit on Enter / tick mark key on keyboard
5. Observe the behavior
6. Open mWeb and do step 2 - 5

Expected Result:

The behavior on both mWeb and Android should be the same.

Actual Result:

On android hitting the enter key does nothing other than closing the keyboard, but on mWeb hitting the enter key on keyboard selects the searched pronoun

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.30-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230618_202315_Chrome.mp4

az_recorder_20230623_183852.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687109264930579

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01763c040cae5d6f20
• Upwork Job ID: 1673255740814970880
• Last Price Increase: 2023-07-17

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jakub-trzebiatowski]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the "Submit" button is pressed on the virtual keyboard, the focused pronouns aren't selected.

What is the root cause of that problem?

While we subscribe to "Enter" key presses via KeyboardShortcut.subscribe, this doesn't work on Native.

What changes do you think we should make in order to solve the problem?

Minor changes should be done to the BaseOptionsSelector component.

We should extract the relevant logic and call it...

• From the callback passed to KeyboardShortcut.subscribe
• From the onSubmitEditing passed to TextInput

Extracted logic:

selectFocusedOption() {
    const focusedOption = this.state.allOptions[this.state.focusedIndex];
    if (!focusedOption || !this.props.isFocused) {
        return;
    }
    if (this.props.canSelectMultipleOptions) {
        this.selectRow(focusedOption);
    } else if (!this.state.shouldDisableRowSelection) {
        this.setState({shouldDisableRowSelection: true});
        let result = this.selectRow(focusedOption);
        if (!(result instanceof Promise)) {
            result = Promise.resolve();
        }
        setTimeout(() => result.finally(() => this.setState({shouldDisableRowSelection: false})), 500);
    }
}

Call from the KeyboardShortcut.subscribe callback:

this.unsubscribeEnter = KeyboardShortcut.subscribe(
    enterConfig.shortcutKey,
    () => {
        this.selectFocusedOption();
    },
    enterConfig.descriptionKey,
    enterConfig.modifiers,
    true,
    () => !this.state.allOptions[this.state.focusedIndex],
);

Call from the onSubmitEditing callback:

<TextInput
    // ...
    onChangeText={this.props.onChangeText}
    onSubmitEditing={()=> {
        this.selectFocusedOption();
    }}
    // ...
/>

My branch

[conorpendergrast]

We see the same behaviour in selecting timezone and currency (during a money request and split) too, by the way!

Timezone	Request - Currency	Split - Currency

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01763c040cae5d6f20

[melvin-bot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.