[HOLD for payment 2023-12-07] [HOLD for payment 2023-10-13] [HOLD for payment 2023-07-14] Onyx migration for personalDetails changes

[puneetlath]

Part of "Secure Logins in NewDot" Project

• Main tracking issue
• Re-keying tracking issue

As part of this project, we started sending new data to Onyx that was accountID-based (e.g. personalDetailsList, participantAccountIDs, etc). We did not stop sending the old data, but we will be soon.

As a cleanup item, we should add an Onyx migration for two reasons:

1. To remove stale data from clients (e.g. to remove the personalDetails object)
2. To fix stale local data that will cause the app to break (e.g. old reportActions that don't have participantAccountIDs)

We should have this ready to go-live after https://github.com/Expensify/Expensify/issues/294647 is done.

This migration will be handled in stages:

Before updating the back-end:

• Migrate reportActions that don't have accountID-based data to include it (without removing email-based data)
  • Note: reportActions are the only pieces of data that can be stale in Onyx and might not be overwritten by the API) (Report actions Onyx migration for accountIDs #21509)

Once back-end has been updated to stop sending email-based data:

• Update the reportActions migration to clear out any email-based data Update PersonalDetails migration of reportActions to remove email-based data #22432
• Update migration to remove email-based data from reports
  • [HOLD E/E#294647] Update PersonalDetails migration of reports to remove email-based data #22811
  • Update migration for report.participants and report.lastActorEmail #28555
  • [No QA] Remove managerEmail and ownerEmail from Onyx #31664
• Update migration to remove the old policyMembersList Remove policyMemberList as part of personalDetails migration #21694
• Update migration to remove the old personalDetails Remove personalDetails as part of personalDetails migration #21844
• Update migration not to run when it isn't needed

[puneetlath]

This migration will be handled in stages:

Before updating the back-end:

• Migrate reportActions that don't have accountID-based data to include it (without removing email-based data)
  • Note: reportActions are the only pieces of data that can be stale in Onyx and might not be overwritten by the API) (Report actions Onyx migration for accountIDs #21509)

Once back-end has been updated to stop sending email-based data:

• Update the reportActions migration to clear out any email-based data
• Update migration to remove email-based data from reports
• Update migration to remove the old policyMembersList Remove policyMemberList as part of personalDetails migration #21694
• Update migration to remove the old personalDetails Remove personalDetails as part of personalDetails migration #21844
• Update migration not to run when it isn't needed

[puneetlath]

@s77rt if you want, you can C+ all of them. There will probably be at least 3 or 4 PRs.

[s77rt]

@puneetlath That would be great