[HOLD for payment 2023-07-12] [$1000] Auth DeletePolicy error is misaligned

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open workspaces
3. Select any workspace and delete it

Expected Result:

If Auth DeletePolicy error is triggered, it should be aligned with workspace avatars as we normally do for other errors

Actual Result:

Auth DeletePolicy error is not aligned with workspace avatars

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

deletepolicy.error.not.aligned.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686578487180049

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ae4f5bbe870cdf89
• Upwork Job ID: 1671580913028014080
• Last Price Increase: 2023-06-21

[ahmedGaber93]

Proposal

Auth DeletePolicy error is misaligned

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

The error padding left in not the same as the item padding left.
Error padding left:

App/src/styles/styles.js

Lines 2832 to 2835 in 332d2c9

	menuItemErrorPadding: {
	paddingLeft: 44,
	paddingRight: 20,
	},

Item padding left:

App/src/styles/styles.js

Line 1299 in 332d2c9

paddingHorizontal: 20,

What changes do you think we should make in order to solve the problem?

Apply the same padding left for both Error and Item

 menuItemErrorPadding: { 
     paddingLeft: 20, 
     paddingRight: 20, 
 }, 

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jeet-dhandha]

I would like to suggest to not get this aligned as this looks more like a error message now rather then when aligned, where it will look more like a workspace.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The error dot is misaligned

What is the root cause of that problem?

This is the currently padding/ margin of dot error in all pages

1. Padding Horizontal 24px

2. Margin Horizontal 20px

3. no padding

4. Padding Horizontal 20px

5. Padding left 44px, padding right 20px

What changes do you think we should make in order to solve the problem?

We need to confirm the padding/margin for each above page. This is my suggestion

1. Padding horizontal 20px

App/src/pages/workspace/WorkspaceInitialPage.js

Line 197 in 7c04c2f

errorRowStyles={[styles.ph6, styles.pv2]}

update styles.ph6 to styles.ph5

2. Look good
3. Padding horizontal 20px
   

   App/src/pages/settings/Profile/Contacts/ContactMethodsPage.js

   Line 96 in 7c04c2f

   <OfflineWithFeedback

Add this props

errorRowStyles={[styles.ph5]}

4. Look good
5. Padding horizontal 20px
   

   App/src/styles/styles.js

   Line 2835 in 7c04c2f

   menuItemErrorPadding: {

   
   update to paddinghorizontal: 20

What alternative solutions did you explore? (Optional)

@Beamanator Could you help to confirm the correct padding margin in above places

[Beamanator]

Maybe @shawnborton can help confirm how we want those to look - and @dukenv0307 it looks like you forced errors to appear in Onyx, right? Maybe you can add some dummy text to each of those screenshots too?

[dukenv0307]

Sorry for my bump mistake
@shawnborton Please help to confirm

[shawnborton]

I'm confused, why are we not showing an error message next to the red dot?

[dukenv0307]

@shawnborton Because this bug focuses on the error being misaligned so I am forcing errors to appear red dot in code without a message. I will update to include message error for more clear

[shawnborton]

Thank you!

[dukenv0307]

@shawnborton I just updated #21143 (comment) Could you help to check? Thanks

[shawnborton]

I think the cleanest thing to do might be to do just Padding Horizontal 20px from your ideas. But I guess it depends, if that error message is already wrapped inside a view that has 20px padding, then we wouldn't need any extra. Let me know if that makes sense.