[HOLD for payment 2023-07-10] [$1000] Report List option is not highlighted on long pressing in LNH

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the App
2. In LNH, long press/right click on any report option

Expected Result:

The Report option should be highlighted to indicate which one is being pinned.

Actual Result:

No option is highlighted and the user cannot see which one is being pinned.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27-2

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-02.at.12.05.45.PM.mov

Expensify/Expensify Issue URL:

Issue reported by: @esh-g

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686629557027629

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01999e34796fd5152c
• Upwork Job ID: 1670922936437043200
• Last Price Increase: 2023-06-19

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

Please restate the problem

Report is not selected in LNH on long pressing for context menu.

What do you think is the root cause of the problem?

We have no logic in place to highlight the selected report in LNH.

What changes do you think we should make to fix that problem?

We should first add a state variable to track the context menu called isContextMenuActive in OptionRowLNH.js.
2. Then in the method showPopover :

App/src/components/LHNOptionsList/OptionRowLHN.js

Lines 93 to 108 in 93957f0

	const showPopover = (event) => {
	ReportActionContextMenu.showContextMenu(
	ContextMenuActions.CONTEXT_MENU_TYPES.REPORT,
	event,
	'',
	popoverAnchor,
	props.reportID,
	{},
	'',
	() => {},
	() => {},
	false,
	false,
	optionItem.isPinned,
	);
	};

We should add setIsContextMenuActive(true) when called and pass () => setIsContextMenuActive(false) to the onHideparameter of the ReportActionContextMenu.showContextMenu
3. Finally on line 137 in OptionRowLNH.js
https://github.com/Expensify/App/blob/93957f0eb66a7e6998365b201a4c54ea2029ff60/src/components/LHNOptionsList/OptionRowLHN.js#LL137C5-L137C5
We need to modify the condition to the following:
props.isFocused || isContextMenuActive
Result:
https://github.com/Expensify/App/assets/77237602/754c692e-e2f7-4778-ac61-e9cdd3b6da6d

What other alternatives did you explore (optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01999e34796fd5152c

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[mallenexpensify]

Pretty sure they can be External. @mollfpr can you please review @esh-g's proposal above?
For the fix/improvement, we def want the highlighting to be clearly visible on all platforms, since Desktop and iOS function differently (and I'm guessing others too)

[mollfpr]

@mallenexpensify Sure; I will review the proposal today!