[HOLD for payment 2023-07-20] [$1000] Dev: Web - Workspace - Calendar disappears when clicking on it

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app on Safari Web
2. Go to settings > workspace >Bank account > connect manually
3. Fill the form until step 3
4. On date of birth field click to add date

Expected Result:

Calendar does not disappear when clicking on it

Actual Result:

Calendar disappears when clicking on it the first time

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.26-1

Reproducible in staging?: n/a

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-10.at.16.24.43.1.mov

Expensify/Expensify Issue URL:

Issue reported by: @narzullome

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686396209206479

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01474c1fe598ac86fd
• Upwork Job ID: 1670876754666561536
• Last Price Increase: 2023-06-26

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kushu7]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Safari - Web - Workspace - Calendar disappears when clicking on it

What is the root cause of that problem?

This bug is limited to Safari only and REPLICATED ON STAGING ALSO. In safari browser DatePicker is visible on click unless chrome we have to click on date-picker icon.
The problem is that when we click on input field. it fires two event. focus and click.
As i said DatePicker is shown in safari on simple click. but here we have onFocus event on DatePicker that is again clicking the input using the ref. that is causing open and close of date picker.

App/src/components/DatePicker/index.js

Lines 49 to 60 in bee8fd3

	/**
	* Pops the datepicker up when we focus this field. This only works on mWeb
	* On mWeb the user needs to tap on the field again in order to bring the datepicker. But our current styles
	* don't make this very obvious. To avoid confusion we open the datepicker when the user focuses the field
	*/
	showDatepicker() {
	if (!this.inputRef) {
	return;
	}
	this.inputRef.click();
	}

This problem is with every Input DatePicker we are using.
eg. Company information - Incorporation date

Repro Step:

1. make sure InputField is not focused
2. try to click on DatePicker

Bug

bug-staging1.mov

What changes do you think we should make in order to solve the problem?

• To solve this problem we can update early return condition to !this.inputRef || !Browser.isMobile() here.
  

  App/src/components/DatePicker/index.js

  Line 55 in bee8fd3

  if (!this.inputRef) {

As we can see this was added basically for mWeb.

App/src/components/DatePicker/index.js

Lines 49 to 54 in bee8fd3

	/**
	* Pops the datepicker up when we focus this field. This only works on mWeb
	* On mWeb the user needs to tap on the field again in order to bring the datepicker. But our current styles
	* don't make this very obvious. To avoid confusion we open the datepicker when the user focuses the field
	*/
	showDatepicker() {

Result

result1.mov

What alternative solutions did you explore? (Optional)

I guess problem is with mobile chrome only. on Focus calendar doesn't get open in mobile chrome.
so maybe we can update condition to !this.inputRef || !Browser.isMobileChrome() only.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01474c1fe598ac86fd

[melvin-bot]

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)