[REPORTING BONUS PAYMENT] [Hold Auth #8141] Web - Search - Two concierge chats and user's own account appears in search

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to a new account
2. Click on search

Expected Result:

Only one concierge chat should appear

Actual Result:

Two concierge chats and user's own account appears in search

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29.0

Reproducible in staging?: yes

Reproducible in production?: no

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @Puneet-here

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686987884987839

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01518684b253e81d9a
• Upwork Job ID: 1673118417921212416
• Last Price Increase: 2023-06-25

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[arosiclair]

Not able to reproduce this in v1.3.29-1

@kbecciv can you try reproducing again?

[arosiclair]

Nevermind I'm able to reproduce with a new @gmail.com account.

However, I can't reproduce in dev:

[arosiclair]

Alright the root cause of this seems to be an API issue. We build the options list using reports and personal details. We filter duplicates here by login. However, the personal details for Concierge has no login for some reason so both the Concierge chat and personal detail are returned. I can confirm we're not returning the login for Concierge in OpenApp:

Other personal details are unaffected and have logins populated.

[arosiclair]

Alright the proper fix for this is #20933 which will filter duplicates by accountID instead of login

[luacmartins]

This Auth PR seems to fix the issue. Gonna remove the label and put this issue on hold for the Auth deploy. We should confirm it's fixed on staging once we deploy Auth.