[HOLD for payment 2023-07-12] [$1000] Error highlighting inconsistent when using 'Fix errors' link

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings.
2. Go to your workspace.
3. Navigate to 'Travel' and connect bank account manually.
4. Add Routing number (074000078) and Account number (1234), then try to continue without accepting the terms.
5. The error will appear, and when clicking on the "Fix errors" link, it does not focus on the error.

Expected Result:

The app should highlight specific errors for the user when they do not accept the terms and an error occurs, similar to how it directs the user to specific errors and highlights them when issues occur with Routing and Account numbers.

Actual Result:

When the user doesn't accept the terms and an error occurs, clicking on the 'Fix errors' link doesn't highlight them.

• This causes confusion since the app highlights specific errors when issues occur with Routing and Account numbers.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.28-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
screen-capture (72).webm

Recording.983.mp4

Recording.983.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686296570841189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018b233772b18dcdce
• Upwork Job ID: 1669783824811683840
• Last Price Increase: 2023-06-16

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Nodebrute]

Fix the error scrolls to where an error occurs. It is working fine. If accept terms checkbox is out of view, fix the errors will scroll to it.

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On clicking fix all errors link, the checkbox border does not change colour.

What is the root cause of that problem?

The root cause of the issue is that the browser is not applying focus-visible to the checkbox when its focused programatically.

What changes do you think we should make in order to solve the problem?

We can add the following here:

 div[role="checkbox"]:focus > div[data-checkbox]

What alternative solutions did you explore? (Optional)

We can control the focus programatically by using onFocus handler and a isFocused state variable. Depending on the value of isFocused, we can apply focus styles.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018b233772b18dcdce

[melvin-bot]

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)