[HOLD for payment 2023-07-12] [$1000] Web -Thread - When deleting the last unread message, the "New" marker briefly appears for a second before disappearing

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1 Open a chat
2. Send a message to the user
3. Click on "Reply in thread"
4. Send two messages in the thread
5. Click on "Mark as unread" on first thread message messages
6. Delete the messages one by one

Expected Result:

The "New" marker should be removed when deleting the unread message

Actual Result:

"New" marker briefly appears when deleting the last message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27.4

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

2023-06-08.12-57-39.mp4

Recording.3113.mp4

Expensify/Expensify Issue URL:

Issue reported by: @ayazhussain79

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686211740166899

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0160cacdcc601320a8
• Upwork Job ID: 1670911841152397312
• Last Price Increase: 2023-06-19

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web -Thread - When deleting the last unread message, the "New" marker briefly appears for a second before disappearing

What is the root cause of that problem?

This because the message content hide immediately depend on pendingAction
props.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE

App/src/components/OfflineWithFeedback.js

Line 97 in b66ad24

const hideChildren = props.shouldHideOnDelete && !props.network.isOffline && props.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && !hasErrors;

But the "New Line" hide after did update in componentDidUpdate and pass newMarkerReportActionID prop down then use it to set prop shouldDisplayNewMarker.

App/src/pages/home/report/ReportActionsView.js

Lines 212 to 218 in 37537ff

	// If the report is unread, we want to check if the number of actions has decreased. If so, then it seems that one of them was deleted. In this case, if the deleted action was the
	// one marking the unread point, we need to recalculate which action should be the unread marker.
	if (ReportUtils.isUnread(this.props.report) && prevProps.reportActions.length > this.props.reportActions.length) {
	this.setState({
	newMarkerReportActionID: ReportUtils.getNewMarkerReportActionID(this.props.report, this.props.reportActions),
	});
	}

What changes do you think we should make in order to solve the problem?

We need to hide the "New Line" immediately like message content by add this additional condition
//props.action.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE

// {props.shouldDisplayNewMarker && <UnreadActionIndicator reportActionID={props.action.reportActionID} />}
{props.shouldDisplayNewMarker && props.action.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && <UnreadActionIndicator reportActionID={props.action.reportActionID} />}

Screen.Recording.2023-06-14.at.7.38.41.PM.mov

What alternative solutions did you explore? (Optional)

we can use the above in high layer when we pass shouldDisplayNewMarker

[melvin-bot]

@anmurali Huh... This is 4 days overdue. Who can take care of this?

[anmurali]

Is the green line what we're referring to as marker? If yes - I see it. But the marked as unread thread does go away from the LHN. There is also another bug. In the main room, this chat still shows 3 replies although it's been deleted. Can we fix them both together? Here is the recording

Screen.Recording.2023-06-19.at.5.45.41.PM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0160cacdcc601320a8

[melvin-bot]

Current assignee @anmurali is eligible for the External assigner, not assigning anyone new.