[HOLD for payment 2023-07-03] [$1000] The current report is not showing in the LHN when using #focus mode

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in to NewDot
2. Set preference to #focus mode
3. Open a new chat or search for any account to start a chat

Expected Result:

Current chat report should be shown in LHN

Actual Result:

Current chat is not showing in the LHN

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27-2
Reproducible in staging?: Needs reproduction ( I can see the report in LHN)
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686164246609519

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01347498877cf1755d
• Upwork Job ID: 1669118311685169152
• Last Price Increase: 2023-06-14

[melvin-bot]

Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The current report is not displayed in LHN when #focus mode is set.

What is the root cause of that problem?

The LHN options are obtained with SidebarUtils.getOrderedReportIDs, and in this function the reports are filtered with ReportUtils.shouldReportBeInOptionList, and if it is the current report, it should be displayed in the LHN.

App/src/libs/ReportUtils.js

Lines 1859 to 1864 in b20f917

	// Include the currently viewed report. If we excluded the currently viewed report, then there
	// would be no way to highlight it in the options list and it would be confusing to users because they lose
	// a sense of context.
	if (report.reportID === reportIDFromRoute) {
	return true;
	}

But the this.props.reportIDFromRoute parameter in the following code is empty and there is no setting.

App/src/pages/home/sidebar/SidebarLinks.js

Line 151 in b20f917

const optionListItems = SidebarUtils.getOrderedReportIDs(this.props.reportIDFromRoute);

So the current report is not displayed in LHN.

What changes do you think we should make in order to solve the problem?

We should set a valid parameter to the SidebarUtils.getOrderedReportIDs.

const optionListItems = SidebarUtils.getOrderedReportIDs(this.props.currentReportId);

What alternative solutions did you explore? (Optional)

None.

[arielgreen]

Reproduced:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01347498877cf1755d

[melvin-bot]

Current assignee @arielgreen is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)