[HOLD for payment 2023-07-05] [$1000] The title of thread in LHN still be attachment after deleting this attachment

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Send an attachment
3. Reply in the above attachment
4. Observe that new reply chat is created in LHN with title [Attachment]
5. Delete above attachment

Expected Result:

Title in LHN still be [Deleted message]

Actual Result:

Title in LHN still be [Attachment]

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: n/a

Reproducible in staging?: n/a

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-27.at.21.55.46.mov

Expensify/Expensify Issue URL:

Issue reported by: @dukenv0307

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685199666223399

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01385d7c536631fa3d
• Upwork Job ID: 1671638587937628160
• Last Price Increase: 2023-06-21

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The title of thread in LHN still be attachment after deleting this attachment

What is the root cause of that problem?

App/src/libs/ReportUtils.js

Lines 1112 to 1118 in 414dc10

	const isAttachment = _.has(parentReportAction, 'isAttachment') ? parentReportAction.isAttachment : isReportMessageAttachment(_.last(lodashGet(parentReportAction, 'message', [{}])));
	if (isAttachment) {
	return `[${Localize.translateLocal('common.attachment')}]`;
	}
	const parentReportActionMessage = lodashGet(parentReportAction, ['message', 0, 'text'], '').replace(/(\r\n|\n|\r)/gm, ' ');
	return parentReportActionMessage || Localize.translateLocal('parentReportAction.deletedMessage');
	}

If the parent report action is attachment, we will return [Attachment] text immediately

What changes do you think we should make in order to solve the problem?

We should add a condition to check if this attachment been deleted or not

const isDelete = lodashGet(parentReportAction, [‘message’, 0, ‘isDeletedParentAction’], false);

and add into the if statement like this

  if (isAttachment && !isDelete) {
            return `[${Localize.translateLocal(‘common.attachment’)}]`;
  }

What alternative solutions did you explore? (Optional)

[dukenv0307]

I can't edit my original proposal. So I Post new comment to give an alternative solution

What alternative solutions did you explore? (Optional)

Because parentReportActionMessage will be '' if the attachment is deleted so we also use parentReportActionMessage to check if this attachment is deleted or not like this

const parentReportActionMessage = lodashGet(parentReportAction, ['message', 0, 'text'], '').replace(/(\r\n|\n|\r)/gm, ' ');
if (isAttachment && parentReportActionMessage) {
            return `[${Localize.translateLocal('common.attachment')}]`;
}

Result

Both proposal work well

Screen.Recording.2023-06-12.at.19.13.16.mov

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The thread title in LHN does not change to Deleted Message when the parent action of attachment is deleted.

What is the root cause of that problem?

The title in LHN comes from ReportUtils.getReportName.

App/src/libs/SidebarUtils.js

Lines 337 to 339 in 0a471b0

	const reportName = ReportUtils.getReportName(report);
	result.text = reportName;

If it's a thread and it's an attachment, we will always return [Attachment].

App/src/libs/ReportUtils.js

Lines 972 to 984 in 0a471b0

	if (isThread(report)) {
	const parentReportAction = ReportActionsUtils.getParentReportAction(report);
	if (ReportActionsUtils.isTransactionThread(parentReportAction)) {
	return getTransactionReportName(parentReportAction);
	}
	const isAttachment = _.has(parentReportAction, 'isAttachment') ? parentReportAction.isAttachment : isReportMessageAttachment(_.last(lodashGet(parentReportAction, 'message', [{}])));
	if (isAttachment) {
	return `[${Localize.translateLocal('common.attachment')}]`;
	}
	const parentReportActionMessage = lodashGet(parentReportAction, ['message', 0, 'text'], '').replace(/(\r\n|\n|\r)/gm, ' ');
	return parentReportActionMessage || Localize.translateLocal('parentReportAction.deletedMessage');
	}

Notice that we are checking 2 things to detect whether this action is an attachment or not.

1. Check if the action has isAttachment property and return that
2. Else, use isReportMessageAttachment. This will check the action message text and html.

When we delete an action, both html and text of a message becomes an empty string.

App/src/libs/actions/Report.js

Lines 812 to 820 in 0a471b0

	const deletedMessage = [
	{
	type: 'COMMENT',
	html: '',
	text: '',
	isEdited: true,
	isDeletedParentAction: true,
	},
	];

This means, the 2nd check above will return false, but the first check still returns true because isAttachment is never updated when we delete an action.

What changes do you think we should make in order to solve the problem?

First of all, isAttachment attribute is just a local attribute. This means that this attribute never exist in BE, so when we reload/relogin, you won't be able to find isAttachment anymore. So, I think the better thing to do is to not rely on isAttachment and just simply use isReportMessageAttachment like we did in a few places here:

App/src/libs/SidebarUtils.js

Lines 270 to 274 in 0a471b0

	if (ReportUtils.isReportMessageAttachment({text: report.lastMessageText, html: report.lastMessageHtml})) {
	lastMessageTextFromReport = `[${Localize.translateLocal('common.attachment')}]`;
	} else {
	lastMessageTextFromReport = report ? report.lastMessageText || '' : '';
	}

App/src/libs/OptionsListUtils.js

Lines 440 to 444 in 0a471b0

	if (ReportUtils.isReportMessageAttachment({text: report.lastMessageText, html: report.lastMessageHtml})) {
	lastMessageTextFromReport = `[${Localize.translateLocal('common.attachment')}]`;
	} else {
	lastMessageTextFromReport = report ? report.lastMessageText || '' : '';
	}

What alternative solutions did you explore? (Optional)

Update isAttachment to false when delete an action.

[alexpensify]

This one is on my review list

[alexpensify]

I'm able to replicate it, now checking if this one is being worked on in another GH.

[alexpensify]

@rushatgabhane and @tylerkaraszewski - this one seems pretty similar to the GH you are assigned here:

(#19913)

Should we consolidate this GH into the one above?

[alexpensify]

No update